Chromium Code Reviews| Index: third_party/WebKit/Source/web/WebDOMFileSystem.cpp |
| diff --git a/third_party/WebKit/Source/web/WebDOMFileSystem.cpp b/third_party/WebKit/Source/web/WebDOMFileSystem.cpp |
| index 4c91e7d94cbec14b2a0cf20614426779314fb534..4d34d58a609ef83933682b12a5814b673e134e85 100644 |
| --- a/third_party/WebKit/Source/web/WebDOMFileSystem.cpp |
| +++ b/third_party/WebKit/Source/web/WebDOMFileSystem.cpp |
| @@ -49,7 +49,7 @@ WebDOMFileSystem WebDOMFileSystem::fromV8Value(v8::Local<v8::Value> value) |
| return WebDOMFileSystem(); |
| v8::Local<v8::Object> object = v8::Local<v8::Object>::Cast(value); |
| DOMFileSystem* domFileSystem = V8DOMFileSystem::toImpl(object); |
| - ASSERT(domFileSystem); |
| + DCHECK(domFileSystem); |
| return WebDOMFileSystem(domFileSystem); |
| } |
| @@ -68,7 +68,7 @@ WebDOMFileSystem WebDOMFileSystem::create( |
| const WebURL& rootURL, |
| SerializableType serializableType) |
| { |
| - ASSERT(frame && toWebLocalFrameImpl(frame)->frame()); |
| + DCHECK(frame && toWebLocalFrameImpl(frame)->frame()); |
|
tkent
2016/03/31 23:05:21
Please split this into two.
DCHECK(frame);
|
| DOMFileSystem* domFileSystem = DOMFileSystem::create(toWebLocalFrameImpl(frame)->frame()->document(), name, static_cast<FileSystemType>(type), rootURL); |
| if (serializableType == SerializableTypeSerializable) |
| domFileSystem->makeClonable(); |
| @@ -87,13 +87,13 @@ void WebDOMFileSystem::assign(const WebDOMFileSystem& other) |
| WebString WebDOMFileSystem::name() const |
| { |
| - ASSERT(m_private.get()); |
| + DCHECK(m_private.get()); |
| return m_private->name(); |
| } |
| WebFileSystem::Type WebDOMFileSystem::type() const |
| { |
| - ASSERT(m_private.get()); |
| + DCHECK(m_private.get()); |
| switch (m_private->type()) { |
| case FileSystemTypeTemporary: |
| return WebFileSystem::TypeTemporary; |
| @@ -111,7 +111,7 @@ WebFileSystem::Type WebDOMFileSystem::type() const |
| WebURL WebDOMFileSystem::rootURL() const |
| { |
| - ASSERT(m_private.get()); |
| + DCHECK(m_private.get()); |
| return m_private->rootURL(); |
| } |
| @@ -119,7 +119,7 @@ v8::Local<v8::Value> WebDOMFileSystem::toV8Value(v8::Local<v8::Object> creationC |
| { |
| // We no longer use |creationContext| because it's often misused and points |
| // to a context faked by user script. |
| - ASSERT(creationContext->CreationContext() == isolate->GetCurrentContext()); |
| + DCHECK(creationContext->CreationContext() == isolate->GetCurrentContext()); |
| if (!m_private.get()) |
| return v8::Local<v8::Value>(); |
| return toV8(m_private.get(), isolate->GetCurrentContext()->Global(), isolate); |
| @@ -133,12 +133,12 @@ v8::Local<v8::Value> WebDOMFileSystem::createV8Entry( |
| { |
| // We no longer use |creationContext| because it's often misused and points |
| // to a context faked by user script. |
| - ASSERT(creationContext->CreationContext() == isolate->GetCurrentContext()); |
| + DCHECK(creationContext->CreationContext() == isolate->GetCurrentContext()); |
| if (!m_private.get()) |
| return v8::Local<v8::Value>(); |
| if (entryType == EntryTypeDirectory) |
| return toV8(DirectoryEntry::create(m_private.get(), path), isolate->GetCurrentContext()->Global(), isolate); |
| - ASSERT(entryType == EntryTypeFile); |
| + DCHECK_EQ(entryType, EntryTypeFile); |
| return toV8(FileEntry::create(m_private.get(), path), isolate->GetCurrentContext()->Global(), isolate); |
| } |