Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebNode.cpp ('k') | third_party/WebKit/Source/web/WebPluginContainerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
index 5b7c2bab5db37629efc58b86f16af7b484da5108..6c16c2f303a298b326c67906289638e038ef7175 100644
--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
@@ -81,7 +81,7 @@ private:
explicit PagePopupChromeClient(WebPagePopupImpl* popup)
: m_popup(popup)
{
- ASSERT(m_popup->widgetClient());
+ DCHECK(m_popup->widgetClient());
}
void closeWindowSoon() override
@@ -123,7 +123,7 @@ private:
m_popup->m_webView->scheduleAnimation();
if (m_popup->isAcceleratedCompositingActive()) {
- ASSERT(m_popup->m_layerTreeView);
+ DCHECK(m_popup->m_layerTreeView);
m_popup->m_layerTreeView->setNeedsBeginFrame();
return;
}
@@ -238,18 +238,18 @@ WebPagePopupImpl::WebPagePopupImpl(WebWidgetClient* client)
, m_rootGraphicsLayer(0)
, m_isAcceleratedCompositingActive(false)
{
- ASSERT(client);
+ DCHECK(client);
}
WebPagePopupImpl::~WebPagePopupImpl()
{
- ASSERT(!m_page);
+ DCHECK(!m_page);
}
bool WebPagePopupImpl::initialize(WebViewImpl* webView, PagePopupClient* popupClient)
{
- ASSERT(webView);
- ASSERT(popupClient);
+ DCHECK(webView);
+ DCHECK(popupClient);
m_webView = webView;
m_popupClient = popupClient;
@@ -288,9 +288,9 @@ bool WebPagePopupImpl::initializePage()
if (AXObjectCache* cache = m_popupClient->ownerElement().document().existingAXObjectCache())
cache->childrenChanged(&m_popupClient->ownerElement());
- ASSERT(frame->localDOMWindow());
+ DCHECK(frame->localDOMWindow());
PagePopupSupplement::install(*frame, *this, m_popupClient);
- ASSERT(m_popupClient->ownerElement().document().existingAXObjectCache() == frame->document()->existingAXObjectCache());
+ DCHECK_EQ(m_popupClient->ownerElement().document().existingAXObjectCache(), frame->document()->existingAXObjectCache());
RefPtr<SharedBuffer> data = SharedBuffer::create();
m_popupClient->writeDocument(data.get());
@@ -325,7 +325,7 @@ AXObject* WebPagePopupImpl::rootAXObject()
if (!document)
return 0;
AXObjectCache* cache = document->axObjectCache();
- ASSERT(cache);
+ DCHECK(cache);
return toAXObjectCacheImpl(cache)->getOrCreate(document->layoutView());
}
@@ -535,7 +535,7 @@ void WebPagePopupImpl::layoutAndPaintAsync(WebLayoutAndPaintAsyncCallback* callb
void WebPagePopupImpl::compositeAndReadbackAsync(WebCompositeAndReadbackAsyncCallback* callback)
{
- ASSERT(isAcceleratedCompositingActive());
+ DCHECK(isAcceleratedCompositingActive());
m_layerTreeView->compositeAndReadbackAsync(callback);
}
« no previous file with comments | « third_party/WebKit/Source/web/WebNode.cpp ('k') | third_party/WebKit/Source/web/WebPluginContainerImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698