third_party/WebKit/Source/web/WebNode.cpp - Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebNode.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/WebMediaDevicesRequest.cpp ('k') | third_party/WebKit/Source/web/WebPagePopupImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebNode.cpp

diff --git a/third_party/WebKit/Source/web/WebNode.cpp b/third_party/WebKit/Source/web/WebNode.cpp

index 9bdeae6462c67eb544d205743cc52b69effc4e68..25e5e5c944eb65b9ec4f710ad0c9102763c3c0c3 100644

--- a/third_party/WebKit/Source/web/WebNode.cpp

+++ b/third_party/WebKit/Source/web/WebNode.cpp

@@ -248,7 +248,7 @@ WebElement WebNode::querySelector(const WebString& selector) const

{

WebExceptionCode ec = 0;

WebElement element = querySelector(selector, ec);

- ASSERT(!ec);

+ DCHECK(!ec);

return element;

}

@@ -272,7 +272,7 @@ void WebNode::querySelectorAll(const WebString& selector, WebVector<WebElement>&

{

WebExceptionCode ec = 0;

querySelectorAll(selector, results, ec);

- ASSERT(!ec);

+ DCHECK(!ec);

}

bool WebNode::focused() const

« no previous file with comments | « third_party/WebKit/Source/web/WebMediaDevicesRequest.cpp ('k') | third_party/WebKit/Source/web/WebPagePopupImpl.cpp » ('j') | no next file with comments »