third_party/WebKit/Source/web/WebDataSourceImpl.cpp - Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebDataSourceImpl.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/WebDataSourceImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebDataSourceImpl.cpp b/third_party/WebKit/Source/web/WebDataSourceImpl.cpp

index 03b0c522cffb44630191907448d374c99c29cdb7..8bd0ea0d226ef53d8be4b86507693f8f3d5ab7bc 100644

--- a/third_party/WebKit/Source/web/WebDataSourceImpl.cpp

+++ b/third_party/WebKit/Source/web/WebDataSourceImpl.cpp

@@ -138,7 +138,7 @@ WebDataSourceImpl::WebDataSourceImpl(LocalFrame* frame, const ResourceRequest& r

WebDataSourceImpl::~WebDataSourceImpl()

{

// Verify that detachFromFrame() has been called.

- ASSERT(!m_extraData);

+ DCHECK(!m_extraData);

}

void WebDataSourceImpl::detachFromFrame()

« no previous file with comments | « third_party/WebKit/Source/web/WebDOMFileSystem.cpp ('k') | third_party/WebKit/Source/web/WebDevToolsAgentImpl.h » ('j') | no next file with comments »