Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: third_party/WebKit/Source/web/WebDOMFileSystem.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebDOMFileSystem.cpp
diff --git a/third_party/WebKit/Source/web/WebDOMFileSystem.cpp b/third_party/WebKit/Source/web/WebDOMFileSystem.cpp
index 4c91e7d94cbec14b2a0cf20614426779314fb534..3fb400134fedb8f06bafa3bdc5942587b15df6a7 100644
--- a/third_party/WebKit/Source/web/WebDOMFileSystem.cpp
+++ b/third_party/WebKit/Source/web/WebDOMFileSystem.cpp
@@ -49,7 +49,7 @@ WebDOMFileSystem WebDOMFileSystem::fromV8Value(v8::Local<v8::Value> value)
return WebDOMFileSystem();
v8::Local<v8::Object> object = v8::Local<v8::Object>::Cast(value);
DOMFileSystem* domFileSystem = V8DOMFileSystem::toImpl(object);
- ASSERT(domFileSystem);
+ DCHECK(domFileSystem);
return WebDOMFileSystem(domFileSystem);
}
@@ -68,7 +68,8 @@ WebDOMFileSystem WebDOMFileSystem::create(
const WebURL& rootURL,
SerializableType serializableType)
{
- ASSERT(frame && toWebLocalFrameImpl(frame)->frame());
+ DCHECK(frame);
+ DCHECK(toWebLocalFrameImpl(frame)->frame());
DOMFileSystem* domFileSystem = DOMFileSystem::create(toWebLocalFrameImpl(frame)->frame()->document(), name, static_cast<FileSystemType>(type), rootURL);
if (serializableType == SerializableTypeSerializable)
domFileSystem->makeClonable();
@@ -87,13 +88,13 @@ void WebDOMFileSystem::assign(const WebDOMFileSystem& other)
WebString WebDOMFileSystem::name() const
{
- ASSERT(m_private.get());
+ DCHECK(m_private.get());
return m_private->name();
}
WebFileSystem::Type WebDOMFileSystem::type() const
{
- ASSERT(m_private.get());
+ DCHECK(m_private.get());
switch (m_private->type()) {
case FileSystemTypeTemporary:
return WebFileSystem::TypeTemporary;
@@ -111,7 +112,7 @@ WebFileSystem::Type WebDOMFileSystem::type() const
WebURL WebDOMFileSystem::rootURL() const
{
- ASSERT(m_private.get());
+ DCHECK(m_private.get());
return m_private->rootURL();
}
@@ -119,7 +120,7 @@ v8::Local<v8::Value> WebDOMFileSystem::toV8Value(v8::Local<v8::Object> creationC
{
// We no longer use |creationContext| because it's often misused and points
// to a context faked by user script.
- ASSERT(creationContext->CreationContext() == isolate->GetCurrentContext());
+ DCHECK(creationContext->CreationContext() == isolate->GetCurrentContext());
if (!m_private.get())
return v8::Local<v8::Value>();
return toV8(m_private.get(), isolate->GetCurrentContext()->Global(), isolate);
@@ -133,12 +134,12 @@ v8::Local<v8::Value> WebDOMFileSystem::createV8Entry(
{
// We no longer use |creationContext| because it's often misused and points
// to a context faked by user script.
- ASSERT(creationContext->CreationContext() == isolate->GetCurrentContext());
+ DCHECK(creationContext->CreationContext() == isolate->GetCurrentContext());
if (!m_private.get())
return v8::Local<v8::Value>();
if (entryType == EntryTypeDirectory)
return toV8(DirectoryEntry::create(m_private.get(), path), isolate->GetCurrentContext()->Global(), isolate);
- ASSERT(entryType == EntryTypeFile);
+ DCHECK_EQ(entryType, EntryTypeFile);
return toV8(FileEntry::create(m_private.get(), path), isolate->GetCurrentContext()->Global(), isolate);
}
« no previous file with comments | « third_party/WebKit/Source/web/WebDOMActivityLogger.cpp ('k') | third_party/WebKit/Source/web/WebDataSourceImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698