third_party/WebKit/Source/web/RotationViewportAnchor.cpp - Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/RotationViewportAnchor.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/RemoteFrameOwner.cpp ('k') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/RotationViewportAnchor.cpp

diff --git a/third_party/WebKit/Source/web/RotationViewportAnchor.cpp b/third_party/WebKit/Source/web/RotationViewportAnchor.cpp

index 674c9333c60cb8909d666b576d09ff798fbccc84..8cf142521e35d86642241abb76f2f14309e8adc9 100644

--- a/third_party/WebKit/Source/web/RotationViewportAnchor.cpp

+++ b/third_party/WebKit/Source/web/RotationViewportAnchor.cpp

@@ -122,10 +122,10 @@ void RotationViewportAnchor::setAnchor()

return;

// Inner rectangle should be within the outer one.

- ASSERT(outerViewRect.contains(innerViewRect));

+ DCHECK(outerViewRect.contains(innerViewRect));

// Outer rectangle is used as a scale, we need positive width and height.

- ASSERT(!outerViewRect.isEmpty());

+ DCHECK(!outerViewRect.isEmpty());

m_normalizedVisualViewportOffset = FloatSize(innerViewRect.location() - outerViewRect.location());