third_party/WebKit/Source/web/RemoteFrameOwner.cpp - Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/RemoteFrameOwner.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/RemoteFrameOwner.cpp

diff --git a/third_party/WebKit/Source/web/RemoteFrameOwner.cpp b/third_party/WebKit/Source/web/RemoteFrameOwner.cpp

index 9a1270d9d87aa4b3e19b877e4e8c48db12c29925..07da06fcd624abc6675f8147c35e43f640c9deff 100644

--- a/third_party/WebKit/Source/web/RemoteFrameOwner.cpp

+++ b/third_party/WebKit/Source/web/RemoteFrameOwner.cpp

@@ -58,7 +58,7 @@ void RemoteFrameOwner::setContentFrame(Frame& frame)

void RemoteFrameOwner::clearContentFrame()

{

- ASSERT(m_frame->owner() == this);

+ DCHECK_EQ(m_frame->owner(), this);

m_frame = nullptr;

#if !ENABLE(OILPAN)

// Balance the ref() in setContentFrame().

« no previous file with comments | « third_party/WebKit/Source/web/PopupMenuImpl.cpp ('k') | third_party/WebKit/Source/web/RotationViewportAnchor.cpp » ('j') | no next file with comments »