third_party/WebKit/Source/web/LocalFileSystemClient.cpp - Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/LocalFileSystemClient.cpp

Issue 1839643009: RELEASE_ASSERT -> CHECK and ASSERT -> DCHECK in web. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Return DCHECK_IS_ON checks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/LinkHighlightImpl.cpp ('k') | third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/LocalFileSystemClient.cpp

diff --git a/third_party/WebKit/Source/web/LocalFileSystemClient.cpp b/third_party/WebKit/Source/web/LocalFileSystemClient.cpp

index 6587418cb9f024b30d6101bf57845a7fdcce07f4..a48522ce72bcf0597b45968ccec2be9d2f35609a 100644

--- a/third_party/WebKit/Source/web/LocalFileSystemClient.cpp

+++ b/third_party/WebKit/Source/web/LocalFileSystemClient.cpp

@@ -53,19 +53,19 @@ LocalFileSystemClient::~LocalFileSystemClient()

bool LocalFileSystemClient::requestFileSystemAccessSync(ExecutionContext* context)

{

- ASSERT(context);

+ DCHECK(context);

if (context->isDocument()) {

ASSERT_NOT_REACHED();

return false;

}

- ASSERT(context->isWorkerGlobalScope());

+ DCHECK(context->isWorkerGlobalScope());

return WorkerContentSettingsClient::from(*toWorkerGlobalScope(context))->requestFileSystemAccessSync();

}

void LocalFileSystemClient::requestFileSystemAccessAsync(ExecutionContext* context, PassOwnPtr<ContentSettingCallbacks> callbacks)

{

- ASSERT(context);

+ DCHECK(context);

if (!context->isDocument()) {

ASSERT_NOT_REACHED();

return;