Move LayoutObject::previousOffsetForBackwardDeletion() to editing.

Move LayoutObject::previousOffsetForBackwardDeletion() to editing.

Move LayoutObject::previousOffsetForBackwardDeletion to
EditingUtilities.cpp
This CL also introduces some tests for existing behaviors.

BUG=594920
Committed: https://crrev.com/0d0b68569b4cfc83150bfd3114c0c2d53d70b14c
Cr-Commit-Position: refs/heads/master@{#383686}

[Seigo Nonaka, 2016-03-28 07:52:21]

nona@chromium.org changed reviewers:
+ yosin@chromium.org

[Seigo Nonaka, 2016-03-28 07:52:21]

Hi Yosi-san,

Could you kindly take a look?

Thank you.

[yosin_UTC9, 2016-03-28 09:13:03]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2016-03-28 09:13:04]

lgtm

+tkent@ for core.gypi and core/layout review
This patch is split from crrev.com/1832343002

https://codereview.chromium.org/1839613002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObject.h (right):

https://codereview.chromium.org/1839613002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObject.h:1226: //
ImageResourceClient override.
Good catch!

[tkent, 2016-03-29 00:00:48]

https://codereview.chromium.org/1839613002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/1839613002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:55: #include
"third_party/icu/source/common/unicode/utf16.h"
I think wtf/unicode/Unicode.h provides U16_IS_TRAIL.

[Seigo Nonaka, 2016-03-29 04:38:47]

Thank you for your review.
By using Unicode.h I can avoid adding an entry to the DEPS file.

Could you kindly take an another look?

Thank you.

https://codereview.chromium.org/1839613002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/1839613002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:55: #include
"third_party/icu/source/common/unicode/utf16.h"
On 2016/03/29 00:00:48, tkent wrote:
> I think wtf/unicode/Unicode.h provides U16_IS_TRAIL.

Done.

[tkent, 2016-03-29 04:58:10]

lgtm.

One nit.

https://codereview.chromium.org/1839613002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/1839613002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:569:
CHECK(static_cast<unsigned>(current - 1) < text.length());
Should it be CHECK, not DHCECK?  String::operator[] has runtime bounds checking,
and StringImpl::operator[] has ASSERT_WITH_SECURITY_IMPLICATION.

[Seigo Nonaka, 2016-03-29 06:12:07]

Thank you for your review.
Submitting...

https://codereview.chromium.org/1839613002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/1839613002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:569:
CHECK(static_cast<unsigned>(current - 1) < text.length());
On 2016/03/29 04:58:10, tkent wrote:
> Should it be CHECK, not DHCECK?  String::operator[] has runtime bounds
checking,
> and StringImpl::operator[] has ASSERT_WITH_SECURITY_IMPLICATION.

Make sense to me. Changed to DCHECK.
Thank you.

[Seigo Nonaka, 2016-03-29 06:12:11]

The CQ bit was checked by nona@chromium.org

[Seigo Nonaka, 2016-03-29 06:12:11]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org,
tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1839613002/#ps40001
(title: "replace CHECK with DCHECK")

[commit-bot: I haz the power, 2016-03-29 06:12:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1839613002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1839613002/40001

[commit-bot: I haz the power, 2016-03-29 07:34:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-29 07:35:46]

Description was changed from

==========
Move LayoutObject::previousOffsetForBackwardDeletion() to editing.

Move LayoutObject::previousOffsetForBackwardDeletion to
EditingUtilities.cpp
This CL also introduces some tests for existing behaviors.

BUG=594920
==========

to

==========
Move LayoutObject::previousOffsetForBackwardDeletion() to editing.

Move LayoutObject::previousOffsetForBackwardDeletion to
EditingUtilities.cpp
This CL also introduces some tests for existing behaviors.

BUG=594920

Committed: https://crrev.com/0d0b68569b4cfc83150bfd3114c0c2d53d70b14c
Cr-Commit-Position: refs/heads/master@{#383686}
==========

[commit-bot: I haz the power, 2016-03-29 07:35:47]

Patchset 3 (id:??) landed as
https://crrev.com/0d0b68569b4cfc83150bfd3114c0c2d53d70b14c
Cr-Commit-Position: refs/heads/master@{#383686}