third_party/WebKit/Source/core/layout/LayoutText.cpp - Issue 1839613002: Move LayoutObject::previousOffsetForBackwardDeletion() to editing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutText.cpp

Issue 1839613002: Move LayoutObject::previousOffsetForBackwardDeletion() to editing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: replace CHECK with DCHECK Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/LayoutText.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutText.cpp b/third_party/WebKit/Source/core/layout/LayoutText.cpp

index 7e8990d6ec96a62e0d9a80cccbcc5a7fea67c519..131a56667c4ae5b7f68f9702944047bb5787630f 100644

--- a/third_party/WebKit/Source/core/layout/LayoutText.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutText.cpp

@@ -1650,17 +1650,6 @@ unsigned LayoutText::resolvedTextLength() const

return len;

}

-int LayoutText::previousOffsetForBackwardDeletion(int current) const

- // Delete by one code point. Ideally we should delete grapheme where that

- // makes sense. https://crbug.com/587241

- if (U16_IS_TRAIL(m_text[--current]))

- --current;

- if (current < 0)

- current = 0;

- return current;

bool LayoutText::computeCanUseSimpleFontCodePath() const

{

if (m_text.is8Bit())

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutText.h ('k') | no next file » | no next file with comments »