Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1839593002: Revert of Modernize Chinese system font fallback list for Windows (Closed)

Created:
4 years, 9 months ago by kojii
Modified:
4 years, 9 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Modernize Chinese system font fallback list for Windows (patchset #3 id:40001 of https://codereview.chromium.org/1754143002/ ) Reason for revert: Reverting due to a performance regressions. BUG=594268 Original issue's description: > Modernize Chinese system font fallback list for Windows > > Following the change for Japanese in crrev.com/379189, this patch > changes Chinese system font fallback list for Windows to prefer more > modern, post-ClearType era fonts. This change improves font rendering > of generic font families and system fallback on Windows for Chinese > characters, both simplified and traditional. > > Results of Win10 failures where this change affects are reviewed. All > these failures on Win10 are due to changes in fonts and rebaseline > should fix them. Their failure expectations are removed in this patch. > > BUG=579842, 587072 > > Committed: https://crrev.com/5129404af72b720b8074a7277e088b001bd3c9e7 > Cr-Commit-Position: refs/heads/master@{#380435} TBR=eae@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=579842, 587072 Committed: https://crrev.com/8667717dada38aae323b355a493b71f2ee322d32 Cr-Commit-Position: refs/heads/master@{#383469}

Patch Set 1 #

Patch Set 2 : Merge TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kojii
Created Revert of Modernize Chinese system font fallback list for Windows
4 years, 9 months ago (2016-03-27 16:51:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839593002/1
4 years, 9 months ago (2016-03-27 16:51:14 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/9691)
4 years, 9 months ago (2016-03-27 16:53:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839593002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839593002/60001
4 years, 9 months ago (2016-03-27 17:32:02 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 9 months ago (2016-03-27 18:37:24 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-27 18:39:08 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8667717dada38aae323b355a493b71f2ee322d32
Cr-Commit-Position: refs/heads/master@{#383469}

Powered by Google App Engine
This is Rietveld 408576698