Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1754143002: Modernize Chinese system font fallback list for Windows (Closed)

Created:
4 years, 9 months ago by kojii
Modified:
4 years, 9 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modernize Chinese system font fallback list for Windows Following the change for Japanese in crrev.com/379189, this patch changes Chinese system font fallback list for Windows to prefer more modern, post-ClearType era fonts. This change improves font rendering of generic font families and system fallback on Windows for Chinese characters, both simplified and traditional. Results of Win10 failures where this change affects are reviewed. All these failures on Win10 are due to changes in fonts and rebaseline should fix them. Their failure expectations are removed in this patch. BUG=579842, 587072 Committed: https://crrev.com/5129404af72b720b8074a7277e088b001bd3c9e7 Cr-Commit-Position: refs/heads/master@{#380435}

Patch Set 1 #

Patch Set 2 : Merge sc/tc #

Patch Set 3 : TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 5 chunks +22 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
kojii
PTAL.
4 years, 9 months ago (2016-03-10 13:07:46 UTC) #5
eae
LGTM, thank you!
4 years, 9 months ago (2016-03-10 18:15:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754143002/40001
4 years, 9 months ago (2016-03-10 18:16:24 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-10 18:24:45 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/5129404af72b720b8074a7277e088b001bd3c9e7 Cr-Commit-Position: refs/heads/master@{#380435}
4 years, 9 months ago (2016-03-10 18:26:48 UTC) #11
kojii
4 years, 9 months ago (2016-03-27 16:51:09 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1839593002/ by kojii@chromium.org.

The reason for reverting is: Reverting due to a performance regressions.

BUG=594268.

Powered by Google App Engine
This is Rietveld 408576698