Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Issue 183923029: Move login_unittest.py to cros_unittest.py so they run in the fyi waterfall. (Closed)

Created:
6 years, 9 months ago by achuithb
Modified:
6 years, 9 months ago
Reviewers:
Tim Song
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move login_unittest.py to cros_unittest.py so they run in the fyi waterfall. The changes from login_unittest.py include: * Removed testOobeLocalization since it's very specialized. * Apply test.Enabled('chromeos') * browser.Start() is no longer necessary. BUG=NONE TEST=manual NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255257

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -0 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py View 1 chunk +3 lines, -2 lines 0 comments Download
A tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py View 1 chunk +170 lines, -0 lines 0 comments Download
A + tools/telemetry/unittest_data/autotest_ext/background.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/telemetry/unittest_data/autotest_ext/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
achuithb
Original test is here: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/telemetry/chromeos/login_unittest.py
6 years, 9 months ago (2014-03-05 01:12:43 UTC) #1
achuithb
6 years, 9 months ago (2014-03-05 01:12:54 UTC) #2
Tim Song
lgtm
6 years, 9 months ago (2014-03-05 19:18:24 UTC) #3
achuithb
The CQ bit was checked by achuith@chromium.org
6 years, 9 months ago (2014-03-05 19:23:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/183923029/1
6 years, 9 months ago (2014-03-05 19:23:32 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 19:28:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 9 months ago (2014-03-05 19:28:38 UTC) #7
achuithb
The CQ bit was checked by achuith@chromium.org
6 years, 9 months ago (2014-03-05 20:10:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/183923029/1
6 years, 9 months ago (2014-03-05 20:11:31 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 20:29:06 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
6 years, 9 months ago (2014-03-05 20:29:07 UTC) #11
achuithb
The CQ bit was checked by achuith@chromium.org
6 years, 9 months ago (2014-03-06 05:25:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/183923029/1
6 years, 9 months ago (2014-03-06 05:26:14 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 05:33:07 UTC) #14
Message was sent while issue was closed.
Change committed as 255257

Powered by Google App Engine
This is Rietveld 408576698