tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py - Issue 183923029: Move login_unittest.py to cros_unittest.py so they run in the fyi waterfall.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

Issue 183923029: Move login_unittest.py to cros_unittest.py so they run in the fyi waterfall. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

index 48daeb367356547392fdf4d01c14fd2e6609efce..7ac981bff6e3f016a9ec7616e7092d808d0ddc83 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py

@@ -270,8 +270,9 @@ class CrOSBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):

self._cri.RmRF(self._login_ext_dir)

self._login_ext_dir = None

- for e in self._extensions_to_load:

- self._cri.RmRF(os.path.dirname(e.local_path))

+ if self._cri:

+ for e in self._extensions_to_load:

+ self._cri.RmRF(os.path.dirname(e.local_path))

self._cri = None

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome/cros_unittest.py » ('j') | no next file with comments »