Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 18391002: dart2js typed_data arrays improvements (Closed)

Created:
7 years, 5 months ago by sra1
Modified:
7 years, 5 months ago
Reviewers:
vsm, floitsch
CC:
reviews_dartlang.org, floitsch, zarah
Visibility:
Public.

Description

Use ListMixin for typed_data arrays make sublist return typed array of same type. Saves ~15k from swarm R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=24713

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+385 lines, -2146 lines) Patch
M sdk/lib/typed_data/dart2js/typed_data_dart2js.dart View 1 4 chunks +333 lines, -2114 lines 0 comments Download
M tests/html/typed_arrays_dataview_test.dart View 1 1 chunk +52 lines, -32 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sra1
+cc Florian & Sarah
7 years, 5 months ago (2013-07-02 16:43:16 UTC) #1
floitsch
LGTM with comments. https://codereview.chromium.org/18391002/diff/7001/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right): https://codereview.chromium.org/18391002/diff/7001/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart#newcode76 sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:76: return list; // TODO: make sure. ...
7 years, 5 months ago (2013-07-02 18:52:15 UTC) #2
sra1
7 years, 5 months ago (2013-07-03 04:03:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r24713 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698