WTF: De-specialize PtrHash<T>.

WTF: De-specialize PtrHash<T>.

PtrHash<T> is specialized over various smart pointer types,
e.g. PtrHash<RefPtr<T>>. However, this abstraction is not necessary;
there's no code requiring the specialized versions, and they are nothing
more than individual class declarations. This patch gets rid of that
abstraction.

Additionally, hash functions for a raw pointer T* are now defined in
PtrHash<T>, instead of PtrHash<T*>, in order to align with other
XXXPtrHash class templates: for example, hash functions for RefPtr<T>
are in RefPtrHash<T>, not in RefPtrHash<RefPtr<T>>. I think my setup
is more idiomatic C++.

BUG=581524
Committed: https://crrev.com/ea9e9b39e9d5501f47d4d4d17dff59601985eaf4
Cr-Commit-Position: refs/heads/master@{#383897}

[Yuta Kitamura, 2016-03-29 08:25:28]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 08:25:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1839003002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1839003002/1

[Yuta Kitamura, 2016-03-29 08:26:18]

Description was changed from

==========
WTF: De-specialize PtrHash<T>.

PtrHash<T> is specialized over various smart pointer types,
e.g. PtrHash<RefPtr<T>>. However, this abstraction is not necessary;
there's no code requiring the specialized versions, and they are nothing
more than individual class declarations. This patch gets rid of that
abstraction.

Additionally, hash functions for a raw pointer T* are now defined in
PtrHash<T>, instead of PtrHash<T*>, in order to align with other
XXXPtrHash class templates: for example, hash functions for RefPtr<T>
are in RefPtrHash<T>, not in RefPtrHash<RefPtr<T>>. I think my setup
is more idiomatic C++.

BUG=581524
==========

to

==========
WTF: De-specialize PtrHash<T>.

PtrHash<T> is specialized over various smart pointer types,
e.g. PtrHash<RefPtr<T>>. However, this abstraction is not necessary;
there's no code requiring the specialized versions, and they are nothing
more than individual class declarations. This patch gets rid of that
abstraction.

Additionally, hash functions for a raw pointer T* are now defined in
PtrHash<T>, instead of PtrHash<T*>, in order to align with other
XXXPtrHash class templates: for example, hash functions for RefPtr<T>
are in RefPtrHash<T>, not in RefPtrHash<RefPtr<T>>. I think my setup
is more idiomatic C++.

BUG=581524
==========

[Yuta Kitamura, 2016-03-29 08:26:18]

yutak@chromium.org changed reviewers:
+ haraken@chromium.org, tzik@chromium.org

[Yuta Kitamura, 2016-03-29 08:26:18]

yutak@chromium.org changed required reviewers:
+ haraken@chromium.org, tzik@chromium.org

[Yuta Kitamura, 2016-03-29 08:32:58]

tzik, haraken: PTAL? This is mostly cosmetic.

Background:
I've started to realize that I need to tweak HashFunctions.h
a little bit, but the code is rather legacy and requires
some surgery before I work on real stuff.

https://codereview.chromium.org/1839003002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/HashFunctions.h (right):

https://codereview.chromium.org/1839003002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/HashFunctions.h:228: };
webkit-lint doesn't like one-liner class declaration
containing "using X = Y". Meh...

[Yuta Kitamura, 2016-03-29 08:34:36]

The CQ bit was checked by yutak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 08:34:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1839003002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1839003002/20001

[haraken, 2016-03-29 08:43:16]

LGTM

[commit-bot: I haz the power, 2016-03-29 11:45:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 11:45:50]

Dry run: This issue passed the CQ dry run.

[tzik, 2016-03-29 12:34:04]

lgtm

https://codereview.chromium.org/1839003002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/heap/Handle.h (right):

https://codereview.chromium.org/1839003002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/heap/Handle.h:1381: static bool equal(const
blink::Member<T>& a, T* b) { return a == b; }
Can we remove overloaded equal()s above?

[Yuta Kitamura, 2016-03-29 23:29:43]

https://codereview.chromium.org/1839003002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/heap/Handle.h (right):

https://codereview.chromium.org/1839003002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/heap/Handle.h:1381: static bool equal(const
blink::Member<T>& a, T* b) { return a == b; }
On 2016/03/29 12:34:04, tzik wrote:
> Can we remove overloaded equal()s above?

Yeah, these sound like extra. Fixed.

[Yuta Kitamura, 2016-03-29 23:29:43]

https://codereview.chromium.org/1839003002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/heap/Handle.h (right):

https://codereview.chromium.org/1839003002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/heap/Handle.h:1381: static bool equal(const
blink::Member<T>& a, T* b) { return a == b; }
On 2016/03/29 12:34:04, tzik wrote:
> Can we remove overloaded equal()s above?

Yeah, these sound like extra. Fixed.

[Yuta Kitamura, 2016-03-29 23:29:51]

The CQ bit was checked by yutak@chromium.org

[Yuta Kitamura, 2016-03-29 23:29:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tzik@chromium.org
Link to the patchset: https://codereview.chromium.org/1839003002/#ps40001
(title: "Remove extra equal() definitions.")

[commit-bot: I haz the power, 2016-03-29 23:30:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1839003002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1839003002/40001

[commit-bot: I haz the power, 2016-03-30 01:32:53]

Description was changed from

==========
WTF: De-specialize PtrHash<T>.

PtrHash<T> is specialized over various smart pointer types,
e.g. PtrHash<RefPtr<T>>. However, this abstraction is not necessary;
there's no code requiring the specialized versions, and they are nothing
more than individual class declarations. This patch gets rid of that
abstraction.

Additionally, hash functions for a raw pointer T* are now defined in
PtrHash<T>, instead of PtrHash<T*>, in order to align with other
XXXPtrHash class templates: for example, hash functions for RefPtr<T>
are in RefPtrHash<T>, not in RefPtrHash<RefPtr<T>>. I think my setup
is more idiomatic C++.

BUG=581524
==========

to

==========
WTF: De-specialize PtrHash<T>.

PtrHash<T> is specialized over various smart pointer types,
e.g. PtrHash<RefPtr<T>>. However, this abstraction is not necessary;
there's no code requiring the specialized versions, and they are nothing
more than individual class declarations. This patch gets rid of that
abstraction.

Additionally, hash functions for a raw pointer T* are now defined in
PtrHash<T>, instead of PtrHash<T*>, in order to align with other
XXXPtrHash class templates: for example, hash functions for RefPtr<T>
are in RefPtrHash<T>, not in RefPtrHash<RefPtr<T>>. I think my setup
is more idiomatic C++.

BUG=581524
==========

[commit-bot: I haz the power, 2016-03-30 01:32:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-30 01:34:48]

Description was changed from

==========
WTF: De-specialize PtrHash<T>.

PtrHash<T> is specialized over various smart pointer types,
e.g. PtrHash<RefPtr<T>>. However, this abstraction is not necessary;
there's no code requiring the specialized versions, and they are nothing
more than individual class declarations. This patch gets rid of that
abstraction.

Additionally, hash functions for a raw pointer T* are now defined in
PtrHash<T>, instead of PtrHash<T*>, in order to align with other
XXXPtrHash class templates: for example, hash functions for RefPtr<T>
are in RefPtrHash<T>, not in RefPtrHash<RefPtr<T>>. I think my setup
is more idiomatic C++.

BUG=581524
==========

to

==========
WTF: De-specialize PtrHash<T>.

PtrHash<T> is specialized over various smart pointer types,
e.g. PtrHash<RefPtr<T>>. However, this abstraction is not necessary;
there's no code requiring the specialized versions, and they are nothing
more than individual class declarations. This patch gets rid of that
abstraction.

Additionally, hash functions for a raw pointer T* are now defined in
PtrHash<T>, instead of PtrHash<T*>, in order to align with other
XXXPtrHash class templates: for example, hash functions for RefPtr<T>
are in RefPtrHash<T>, not in RefPtrHash<RefPtr<T>>. I think my setup
is more idiomatic C++.

BUG=581524

Committed: https://crrev.com/ea9e9b39e9d5501f47d4d4d17dff59601985eaf4
Cr-Commit-Position: refs/heads/master@{#383897}
==========

[commit-bot: I haz the power, 2016-03-30 01:34:49]

Patchset 3 (id:??) landed as
https://crrev.com/ea9e9b39e9d5501f47d4d4d17dff59601985eaf4
Cr-Commit-Position: refs/heads/master@{#383897}