Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: third_party/WebKit/Source/wtf/RetainPtr.h

Issue 1839003002: WTF: De-specialize PtrHash<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove extra equal() definitions. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/wtf/ListHashSetTest.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2005, 2006, 2007, 2008, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2005, 2006, 2007, 2008, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12 * Library General Public License for more details. 12 * Library General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU Library General Public License 14 * You should have received a copy of the GNU Library General Public License
15 * along with this library; see the file COPYING.LIB. If not, write to 15 * along with this library; see the file COPYING.LIB. If not, write to
16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17 * Boston, MA 02110-1301, USA. 17 * Boston, MA 02110-1301, USA.
18 * 18 *
19 */ 19 */
20 20
21 #ifndef RetainPtr_h 21 #ifndef RetainPtr_h
22 #define RetainPtr_h 22 #define RetainPtr_h
23 23
24 #include "wtf/HashTableDeletedValueType.h" 24 #include "wtf/HashTableDeletedValueType.h"
25 #include "wtf/HashTraits.h" 25 #include "wtf/HashTraits.h"
26 #include "wtf/TypeTraits.h" 26 #include "wtf/TypeTraits.h"
27 #include <algorithm> 27 #include <algorithm>
28 #include <type_traits>
28 #include <utility> 29 #include <utility>
29 30
30 #if USE(CF) 31 #if USE(CF)
31 #include <CoreFoundation/CoreFoundation.h> 32 #include <CoreFoundation/CoreFoundation.h>
32 #endif 33 #endif
33 34
34 #ifdef __OBJC__ 35 #ifdef __OBJC__
35 #import <Foundation/Foundation.h> 36 #import <Foundation/Foundation.h>
36 #endif 37 #endif
37 38
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
290 return RetainPtr<T>(AdoptNS, o); 291 return RetainPtr<T>(AdoptNS, o);
291 } 292 }
292 293
293 // Helper function for creating a RetainPtr using template argument deduction. 294 // Helper function for creating a RetainPtr using template argument deduction.
294 template <typename T> inline RetainPtr<T> retainPtr(T) WARN_UNUSED_RETURN; 295 template <typename T> inline RetainPtr<T> retainPtr(T) WARN_UNUSED_RETURN;
295 template <typename T> inline RetainPtr<T> retainPtr(T o) 296 template <typename T> inline RetainPtr<T> retainPtr(T o)
296 { 297 {
297 return RetainPtr<T>(o); 298 return RetainPtr<T>(o);
298 } 299 }
299 300
300 template <typename P> struct HashTraits<RetainPtr<P>> : SimpleClassHashTraits<Re tainPtr<P>> { }; 301 template <typename T>
302 struct HashTraits<RetainPtr<T>> : SimpleClassHashTraits<RetainPtr<T>> { };
301 303
302 template <typename P> struct PtrHash<RetainPtr<P>> : PtrHash<typename RetainPtr< P>::PtrType> { 304 template <typename T>
303 using PtrHash<typename RetainPtr<P>::PtrType>::hash; 305 struct RetainPtrHash : PtrHash<typename std::remove_pointer<typename RetainPtr<T >::PtrType>::type> {
304 static unsigned hash(const RetainPtr<P>& key) { return hash(key.get()); } 306 using Base = PtrHash<typename std::remove_pointer<typename RetainPtr<T>::Ptr Type>::type>;
305 using PtrHash<typename RetainPtr<P>::PtrType>::equal; 307 using Base::hash;
306 static bool equal(const RetainPtr<P>& a, const RetainPtr<P>& b) { return a = = b; } 308 static unsigned hash(const RetainPtr<T>& key) { return hash(key.get()); }
307 static bool equal(typename RetainPtr<P>::PtrType a, const RetainPtr<P>& b) { return a == b; } 309 using Base::equal;
308 static bool equal(const RetainPtr<P>& a, typename RetainPtr<P>::PtrType b) { return a == b; } 310 static bool equal(const RetainPtr<T>& a, const RetainPtr<T>& b) { return a = = b; }
311 static bool equal(typename RetainPtr<T>::PtrType a, const RetainPtr<T>& b) { return a == b; }
312 static bool equal(const RetainPtr<T>& a, typename RetainPtr<T>::PtrType b) { return a == b; }
309 }; 313 };
310 314
311 template <typename P> struct DefaultHash<RetainPtr<P>> { typedef PtrHash<RetainP tr<P>> Hash; }; 315 template <typename T>
316 struct DefaultHash<RetainPtr<T>> {
317 using Hash = RetainPtrHash<T>;
318 };
312 319
313 } // namespace WTF 320 } // namespace WTF
314 321
315 using WTF::AdoptCF; 322 using WTF::AdoptCF;
316 using WTF::AdoptNS; 323 using WTF::AdoptNS;
317 using WTF::adoptCF; 324 using WTF::adoptCF;
318 using WTF::adoptNS; 325 using WTF::adoptNS;
319 using WTF::RetainPtr; 326 using WTF::RetainPtr;
320 using WTF::retainPtr; 327 using WTF::retainPtr;
321 328
322 #endif // WTF_RetainPtr_h 329 #endif // WTF_RetainPtr_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/wtf/ListHashSetTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698