Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: ui/keyboard/resources/elements/kb-key-base.html

Issue 183893033: Use a sound pool instead of a single audio tag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@consistant-css
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/keyboard/resources/elements/kb-key-base.html
diff --git a/ui/keyboard/resources/elements/kb-key-base.html b/ui/keyboard/resources/elements/kb-key-base.html
index 5036aa8dc2efbe88c45cd2b33ee93f62326d231b..419c253f150ccb9bbc7f2168ef4cedb720b41b99 100644
--- a/ui/keyboard/resources/elements/kb-key-base.html
+++ b/ui/keyboard/resources/elements/kb-key-base.html
@@ -181,7 +181,7 @@
* @param {detail} The details of the swipe.
*/
onFlick: function(detail) {
- if (!(detail.direction & SWIPE_DIRECTION.UP) || !this.hintTextValue)
rsadam 2014/03/05 19:57:47 Drive by fix.
+ if (!(detail.direction & SwipeDirection.UP) || !this.hintTextValue)
return;
var typeDetails = {char: this.hintTextValue};
this.fire('type-key', typeDetails);

Powered by Google App Engine
This is Rietveld 408576698