Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183893033: Use a sound pool instead of a single audio tag. (Closed)

Created:
6 years, 9 months ago by rsadam
Modified:
6 years, 9 months ago
Reviewers:
kevers
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@consistant-css
Visibility:
Public.

Description

Use a sound pool instead of a single audio tag. BUG=339320 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255429

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -15 lines) Patch
M ui/keyboard/resources/constants.js View 1 2 chunks +10 lines, -2 lines 0 comments Download
M ui/keyboard/resources/elements/kb-key-base.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/elements/kb-keyboard.html View 4 chunks +27 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
rsadam
https://codereview.chromium.org/183893033/diff/40001/ui/keyboard/resources/constants.js File ui/keyboard/resources/constants.js (right): https://codereview.chromium.org/183893033/diff/40001/ui/keyboard/resources/constants.js#newcode80 ui/keyboard/resources/constants.js:80: var SOUND_POOL_SIZE = 10; We'd need ~20 to get ...
6 years, 9 months ago (2014-03-05 19:57:47 UTC) #1
rsadam
6 years, 9 months ago (2014-03-05 20:02:14 UTC) #2
kevers
lgtm https://codereview.chromium.org/183893033/diff/40001/ui/keyboard/resources/constants.js File ui/keyboard/resources/constants.js (right): https://codereview.chromium.org/183893033/diff/40001/ui/keyboard/resources/constants.js#newcode77 ui/keyboard/resources/constants.js:77: * The size of the pool to use ...
6 years, 9 months ago (2014-03-05 22:26:41 UTC) #3
rsadam
https://codereview.chromium.org/183893033/diff/40001/ui/keyboard/resources/constants.js File ui/keyboard/resources/constants.js (right): https://codereview.chromium.org/183893033/diff/40001/ui/keyboard/resources/constants.js#newcode77 ui/keyboard/resources/constants.js:77: * The size of the pool to use for ...
6 years, 9 months ago (2014-03-06 15:49:47 UTC) #4
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 9 months ago (2014-03-06 15:49:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/183893033/60001
6 years, 9 months ago (2014-03-06 15:50:01 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 16:41:23 UTC) #7
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=156404
6 years, 9 months ago (2014-03-06 16:41:23 UTC) #8
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 9 months ago (2014-03-06 16:45:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/183893033/60001
6 years, 9 months ago (2014-03-06 16:45:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/183893033/60001
6 years, 9 months ago (2014-03-06 20:50:22 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 21:12:45 UTC) #12
Message was sent while issue was closed. 
Change committed as 255429

Powered by Google App Engine
This is Rietveld 408576698