ui/keyboard/resources/elements/kb-key-base.html - Issue 183893033: Use a sound pool instead of a single audio tag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/keyboard/resources/elements/kb-key-base.html

Issue 183893033: Use a sound pool instead of a single audio tag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@consistant-css

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/keyboard/resources/elements/kb-key-base.html

diff --git a/ui/keyboard/resources/elements/kb-key-base.html b/ui/keyboard/resources/elements/kb-key-base.html

index 5036aa8dc2efbe88c45cd2b33ee93f62326d231b..419c253f150ccb9bbc7f2168ef4cedb720b41b99 100644

--- a/ui/keyboard/resources/elements/kb-key-base.html

+++ b/ui/keyboard/resources/elements/kb-key-base.html

@@ -181,7 +181,7 @@

* @param {detail} The details of the swipe.

onFlick: function(detail) {

- if (!(detail.direction & SWIPE_DIRECTION.UP) || !this.hintTextValue)

+ if (!(detail.direction & SwipeDirection.UP) || !this.hintTextValue)

return;

var typeDetails = {char: this.hintTextValue};

this.fire('type-key', typeDetails);

« no previous file with comments | « ui/keyboard/resources/constants.js ('k') | ui/keyboard/resources/elements/kb-keyboard.html » ('j') | no next file with comments »