Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183893019: Move HTMLContentElement & HTMLShadowElement out of shadow/ (Closed)

Created:
6 years, 9 months ago by deepak.sa
Modified:
6 years, 9 months ago
CC:
blink-reviews, arv+blink, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, rwlbuis, watchdog-blink-watchlist_google.com, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move HTMLContentElement & HTMLShadowElement out of shadow/ Move HTMLContentElement & HTMLShadowElement out of shadow/ and into html/. Reference CL: https://codereview.chromium.org/27009005/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168530

Patch Set 1 #

Patch Set 2 : Build Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -443 lines) Patch
M Source/core/core.gypi View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/shadow/ComposedTreeWalker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ElementShadow.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLContentElement.h View 1 chunk +95 lines, -2 lines 0 comments Download
A + Source/core/html/HTMLContentElement.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
A + Source/core/html/HTMLContentElement.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/html/HTMLDetailsElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLShadowElement.h View 1 chunk +54 lines, -2 lines 0 comments Download
A + Source/core/html/HTMLShadowElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/html/HTMLShadowElement.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/html/HTMLSummaryElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/InputType.cpp View 2 chunks +1 line, -1 line 0 comments Download
D Source/core/html/shadow/HTMLContentElement.h View 1 chunk +0 lines, -95 lines 0 comments Download
D Source/core/html/shadow/HTMLContentElement.cpp View 1 chunk +0 lines, -120 lines 0 comments Download
D Source/core/html/shadow/HTMLContentElement.idl View 1 chunk +0 lines, -32 lines 0 comments Download
D Source/core/html/shadow/HTMLShadowElement.h View 1 chunk +0 lines, -54 lines 0 comments Download
D Source/core/html/shadow/HTMLShadowElement.cpp View 1 chunk +0 lines, -86 lines 0 comments Download
D Source/core/html/shadow/HTMLShadowElement.idl View 1 chunk +0 lines, -34 lines 0 comments Download
M Source/core/page/FocusController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
deepak.sa
Please have a look.
6 years, 9 months ago (2014-03-04 06:38:28 UTC) #1
abarth-chromium
LGTM Thanks!
6 years, 9 months ago (2014-03-04 06:45:59 UTC) #2
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-04 06:46:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/183893019/1
6 years, 9 months ago (2014-03-04 06:46:51 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 07:29:18 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout&number=21725
6 years, 9 months ago (2014-03-04 07:29:19 UTC) #6
deepak.sa
The CQ bit was checked by deepak.sa@samsung.com
6 years, 9 months ago (2014-03-04 08:39:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/183893019/1
6 years, 9 months ago (2014-03-04 08:40:41 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 09:26:26 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) blink_heap_unittests, blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, ...
6 years, 9 months ago (2014-03-04 09:26:27 UTC) #10
deepak.sa
The CQ bit was checked by deepak.sa@samsung.com
6 years, 9 months ago (2014-03-05 05:43:37 UTC) #11
deepak.sa
The CQ bit was unchecked by deepak.sa@samsung.com
6 years, 9 months ago (2014-03-05 05:43:46 UTC) #12
deepak.sa
The CQ bit was checked by deepak.sa@samsung.com
6 years, 9 months ago (2014-03-05 05:55:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/183893019/20001
6 years, 9 months ago (2014-03-05 05:57:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/183893019/20001
6 years, 9 months ago (2014-03-05 20:56:08 UTC) #15
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 21:02:46 UTC) #16
Message was sent while issue was closed. 
Change committed as 168530

Powered by Google App Engine
This is Rietveld 408576698