Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1838903008: Revert of clang/win: Stop passing -Qunused-arguments. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of clang/win: Stop passing -Qunused-arguments. (patchset #5 id:80001 of https://codereview.chromium.org/1828543003/ ) Reason for revert: Broke https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/5643 gyp: name 'clang' is not defined while evaluating condition 'optimize=="max" and clang==0' in C:\b\build\slave\google-chrome-rel-win\build\src\v8\tools\gyp\v8.gyp Original issue's description: > clang/win: Stop passing -Qunused-arguments. > > All flags except /GS and /GL are accepted by clang-cl by now. To be able > to turn on -Qunused-arguments, don't pass /GS and /GL in clang builds > for now. > > BUG=504658, 598772, 598767 > NOTRY=true > > Committed: https://crrev.com/de51a84b69b5b1dd458c65f6aaf2335f81b57785 > Cr-Commit-Position: refs/heads/master@{#383954} TBR=hans@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504658, 598772, 598767 Committed: https://crrev.com/90c7ceaea4dc9ebab7a43248c3ae29d478219249 Cr-Commit-Position: refs/heads/master@{#383959}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -22 lines) Patch
M build/common.gypi View 4 chunks +2 lines, -15 lines 0 comments Download
M build/config/compiler/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M build/config/win/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
Created Revert of clang/win: Stop passing -Qunused-arguments.
4 years, 8 months ago (2016-03-30 13:05:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838903008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838903008/1
4 years, 8 months ago (2016-03-30 13:05:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 13:06:00 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 13:07:31 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90c7ceaea4dc9ebab7a43248c3ae29d478219249
Cr-Commit-Position: refs/heads/master@{#383959}

Powered by Google App Engine
This is Rietveld 408576698