DescriptionRevert of clang/win: Stop passing -Qunused-arguments. (patchset #5 id:80001 of https://codereview.chromium.org/1828543003/ )
Reason for revert:
Broke https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/5643
gyp: name 'clang' is not defined while evaluating condition 'optimize=="max" and clang==0' in C:\b\build\slave\google-chrome-rel-win\build\src\v8\tools\gyp\v8.gyp
Original issue's description:
> clang/win: Stop passing -Qunused-arguments.
>
> All flags except /GS and /GL are accepted by clang-cl by now. To be able
> to turn on -Qunused-arguments, don't pass /GS and /GL in clang builds
> for now.
>
> BUG=504658, 598772, 598767
> NOTRY=true
>
> Committed: https://crrev.com/de51a84b69b5b1dd458c65f6aaf2335f81b57785
> Cr-Commit-Position: refs/heads/master@{#383954}
TBR=hans@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=504658, 598772, 598767
Committed: https://crrev.com/90c7ceaea4dc9ebab7a43248c3ae29d478219249
Cr-Commit-Position: refs/heads/master@{#383959}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|