build/config/win/BUILD.gn - Issue 1838903008: Revert of clang/win: Stop passing -Qunused-arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/win/BUILD.gn

Issue 1838903008: Revert of clang/win: Stop passing -Qunused-arguments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/win/BUILD.gn

diff --git a/build/config/win/BUILD.gn b/build/config/win/BUILD.gn

index a4ffedc4501a893fba4388b2a3bcb9080ab3ed92..eeb1cab25a6fb6413a663d730450f396ded89e23 100644

--- a/build/config/win/BUILD.gn

+++ b/build/config/win/BUILD.gn

@@ -33,6 +33,7 @@

cflags = [

"/Gy", # Enable function-level linking.

+ "/GS", # Enable buffer security checking.

"/FS", # Preserve previous PDB behavior.

"/bigobj", # Some of our files are bigger than the regular limits.

@@ -40,10 +41,6 @@

# and unsupported but very handy.

"/d2FastFail",

]

- if (!is_clang) {

- # TODO(thakis): Enable this with clang too, https://crbug.com/598767

- cflags += [ "/GS" ] # Enable buffer security checking.

- }

# Force C/C++ mode for the given GN detected file type. This is necessary

# for precompiled headers where the same source file is compiled in both

« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »