Make analyze_test_test less verbose

Make analyze_test_test less verbose

BUG=
R=whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/cfe157a4ff5078c79f4fbcaab5629c8bbef5ed6e

[Johnni Winther, 2016-03-29 10:27:51]

johnniwinther@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2016-03-29 11:56:26]

lgtm

https://codereview.chromium.org/1838903003/diff/1/tests/compiler/dart2js/anal...
File tests/compiler/dart2js/analyze_helper.dart (right):

https://codereview.chromium.org/1838903003/diff/1/tests/compiler/dart2js/anal...
tests/compiler/dart2js/analyze_helper.dart:213: }
Are verbose and showWhitelisted only used together?

then just
handler.verbose = options.contains(Flags.verbose) &&
!options.contains(HIDE_WHITELISTED);


Is is weird that HIDE_WHITELISTED and showWhitelisted have opposite senses.

https://codereview.chromium.org/1838903003/diff/1/tests/compiler/dart2js/anal...
File tests/compiler/dart2js/analyze_test_test.dart (right):

https://codereview.chromium.org/1838903003/diff/1/tests/compiler/dart2js/anal...
tests/compiler/dart2js/analyze_test_test.dart:62: }
No need to process a --hide-whitelisted argument?

[Johnni Winther, 2016-03-30 07:02:30]

https://codereview.chromium.org/1838903003/diff/1/tests/compiler/dart2js/anal...
File tests/compiler/dart2js/analyze_helper.dart (right):

https://codereview.chromium.org/1838903003/diff/1/tests/compiler/dart2js/anal...
tests/compiler/dart2js/analyze_helper.dart:213: }
On 2016/03/29 11:56:26, Bill Hesse wrote:
> Are verbose and showWhitelisted only used together?
> 
> then just
> handler.verbose = options.contains(Flags.verbose) &&
> !options.contains(HIDE_WHITELISTED);
> 
> 
> Is is weird that HIDE_WHITELISTED and showWhitelisted have opposite senses.

Verbose include (some very noisy) info messages which showWhitelisted doesn't,
so they two levels of verboseness.

https://codereview.chromium.org/1838903003/diff/1/tests/compiler/dart2js/anal...
File tests/compiler/dart2js/analyze_test_test.dart (right):

https://codereview.chromium.org/1838903003/diff/1/tests/compiler/dart2js/anal...
tests/compiler/dart2js/analyze_test_test.dart:62: }
On 2016/03/29 11:56:26, Bill Hesse wrote:
> No need to process a --hide-whitelisted argument?

I deliberately med show-whitelisted the default (for all the tests using the
analyzer_helper) since we tend to miss some info when they fail.

[Johnni Winther, 2016-03-30 07:05:02]

Description was changed from

==========
Make analyze_test_test less verbose

BUG=
==========

to

==========
Make analyze_test_test less verbose

BUG=
R=whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/cfe157a4ff5078c79f4fbcaab5629c8bbef5ed6e
==========

[Johnni Winther, 2016-03-30 07:05:03]

Committed patchset #1 (id:1) manually as
cfe157a4ff5078c79f4fbcaab5629c8bbef5ed6e (presubmit successful).