Make analyze_test_test less verbose

tests/compiler/dart2js/analyze_helper.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyze_helper;
 
 import 'dart:async';
 import 'dart:io';
 import 'package:compiler/compiler.dart' as api;
 import 'package:compiler/compiler_new.dart' as new_api;
 import 'package:compiler/src/apiimpl.dart';
 import 'package:compiler/src/commandline_options.dart';
 import 'package:compiler/src/diagnostics/messages.dart' show
     Message,
     MessageKind;
 import 'package:compiler/src/filenames.dart';
 import 'package:compiler/src/source_file_provider.dart';
 import 'package:compiler/src/util/uri_extras.dart';
 
+/// Option for hiding whitelisted messages.
+const String HIDE_WHITELISTED = '--hide-whitelisted';
+
 /**
  * Map of whitelisted warnings and errors.
  *
  * Only add a whitelisting together with a bug report to dartbug.com and add
  * the bug issue number as a comment on the whitelisting.
  *
  * Use an identifiable suffix of the file uri as key. Use a fixed substring of
  * the error/warning message in the list of whitelistings for each file.
  */
 // TODO(johnniwinther): Support canonical URIs as keys and message kinds as
 // values.
 
 class CollectingDiagnosticHandler extends FormattingDiagnosticHandler {
   bool hasWarnings = false;
   bool hasHint = false;
   bool hasErrors = false;
   bool lastWasWhitelisted = false;
+  bool showWhitelisted = true;
 
   Map<String, Map<dynamic/*String|MessageKind*/, int>> whiteListMap
       = new Map<String, Map<dynamic/*String|MessageKind*/, int>>();
 
   CollectingDiagnosticHandler(
       Map<String, List/*<String|MessageKind>*/> whiteList,
       SourceFileProvider provider)
       : super(provider) {
     whiteList.forEach((String file, List/*<String|MessageKind>*/ messageParts) {
       var useMap = new Map<dynamic/*String|MessageKind*/, int>();
@@ skipping 59 matching lines @@
     return false;
   }
 
   @override
   void report(Message message, Uri uri, int begin, int end, String text,
               api.Diagnostic kind) {
     if (kind == api.Diagnostic.WARNING) {
       if (checkWhiteList(uri, message, text)) {
         // Suppress whitelisted warnings.
         lastWasWhitelisted = true;
-        if (verbose) {
+        if (showWhitelisted || verbose) {
           super.report(message, uri, begin, end, text, kind);
         }
         return;
       }
       hasWarnings = true;
     }
     if (kind == api.Diagnostic.HINT) {
       if (checkWhiteList(uri, message, text)) {
         // Suppress whitelisted hints.
         lastWasWhitelisted = true;
-        if (verbose) {
+        if (showWhitelisted || verbose) {
           super.report(message, uri, begin, end, text, kind);
         }
         return;
       }
       hasHint = true;
     }
     if (kind == api.Diagnostic.ERROR) {
       if (checkWhiteList(uri, message, text)) {
         // Suppress whitelisted errors.
         lastWasWhitelisted = true;
-        if (verbose) {
+        if (showWhitelisted || verbose) {
           super.report(message, uri, begin, end, text, kind);
         }
         return;
       }
       hasErrors = true;
     }
     if (kind == api.Diagnostic.INFO && lastWasWhitelisted) {
       return;
     }
     lastWasWhitelisted = false;
@@ skipping 48 matching lines @@
       break;
     case AnalysisMode.ALL:
       options.add(Flags.analyzeAll);
       break;
     case AnalysisMode.TREE_SHAKING:
       break;
   }
   if (options.contains(Flags.verbose)) {
     handler.verbose = true;
   }
+  if (options.contains(HIDE_WHITELISTED)) {
+    handler.showWhitelisted = false;
+  }

[Bill Hesse, 2016/03/29 11:56:26]

Are verbose and showWhitelisted only used together?

then just
handler.verbose = options.contains(Flags.verbose) &&
!options.contains(HIDE_WHITELISTED);


Is is weird that HIDE_WHITELISTED and showWhitelisted have opposite senses.

[Johnni Winther, 2016/03/30 07:02:30]

Verbose include (some very noisy) info messages which showWhitelisted doesn't,
so they two levels of verboseness.

   var compiler = new CompilerImpl(
       provider,
       null,
       handler,
       new new_api.CompilerOptions.parse(
           libraryRoot: libraryRoot,
           packageRoot: packageRoot,
           options: options,
           environment: {}));
   String MESSAGE = """
 
 
 ===
 === ERROR: Unexpected result of analysis.
 ===
 === Please update [WHITE_LIST] in $testFileName
 ===
 """;
 
   if (mode == AnalysisMode.URI) {
     for (Uri uri in uriList) {
+      print('Analyzing uri: $uri');
       await compiler.analyzeUri(uri);
     }
   } else if (mode != AnalysisMode.TREE_SHAKING) {
+    print('Analyzing libraries: $uriList');
     compiler.librariesToAnalyzeWhenRun = uriList;
     await compiler.run(null);
   } else {
+    print('Analyzing entry point: ${uriList.single}');
     await compiler.run(uriList.single);
   }
 
   bool result;
   if (checkResults != null) {
     result = checkResults(compiler, handler);
   } else {
     result = handler.checkResults();
   }
   if (!result) {
     print(MESSAGE);
     exit(1);
   }
 }