Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Unified Diff: telemetry/telemetry/internal/util/binary_manager_unittest.py

Issue 1838863002: Change telemetry run_tests.py to prefetch all binaries before tests in parallel (Closed) Base URL: https://github.com/catapult-project/catapult@master
Patch Set: Fix bug in DependencyManager.PrefetchPaths Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/util/binary_manager_unittest.py
diff --git a/telemetry/telemetry/internal/util/binary_manager_unittest.py b/telemetry/telemetry/internal/util/binary_manager_unittest.py
index 2c7f79dd879d135c9088149d8b8a7c7ffcc48889..3f3bcd0837a2dd91fd0bff769b6b42cedbe58a41 100644
--- a/telemetry/telemetry/internal/util/binary_manager_unittest.py
+++ b/telemetry/telemetry/internal/util/binary_manager_unittest.py
@@ -19,10 +19,8 @@ class BinaryManagerTest(unittest.TestCase):
def tearDown(self):
binary_manager._binary_manager = self.actual_binary_manager
- @mock.patch(
- 'telemetry.internal.util.binary_manager.binary_manager.BinaryManager') # pylint: disable=line-too-long
- @mock.patch(
- 'telemetry.internal.util.binary_manager.base_config.BaseConfig')
+ @mock.patch('catapult_base.binary_manager.BinaryManager')
+ @mock.patch('dependency_manager.BaseConfig')
def testInitializationNoEnvironmentConfig(
self, base_config_mock, binary_manager_mock):
base_config_mock.side_effect = ['base_config_object1',
@@ -38,10 +36,8 @@ class BinaryManagerTest(unittest.TestCase):
binary_manager_mock.assert_called_once_with(['base_config_object1',
'base_config_object2'])
- @mock.patch(
- 'telemetry.internal.util.binary_manager.binary_manager.BinaryManager') # pylint: disable=line-too-long
- @mock.patch(
- 'telemetry.internal.util.binary_manager.base_config.BaseConfig')
+ @mock.patch('catapult_base.binary_manager.BinaryManager')
+ @mock.patch('dependency_manager.BaseConfig')
def testInitializationWithEnvironmentConfig(
self, base_config_mock, binary_manager_mock):
base_config_mock.side_effect = ['base_config_object1', # TELEMETRY_PROJECT
@@ -62,10 +58,8 @@ class BinaryManagerTest(unittest.TestCase):
self.assertRaises(exceptions.InitializationError,
binary_manager.InitDependencyManager, None)
- @mock.patch(
- 'telemetry.internal.util.binary_manager.binary_manager.BinaryManager') # pylint: disable=line-too-long
- @mock.patch(
- 'telemetry.internal.util.binary_manager.base_config.BaseConfig')
+ @mock.patch('catapult_base.binary_manager.BinaryManager')
+ @mock.patch('dependency_manager.BaseConfig')
def testFetchPathInitialized(self, base_config_mock, binary_manager_mock):
base_config_mock.return_value = 'base_config_object'
expected = [mock.call.binary_manager.BinaryManager(
@@ -86,10 +80,8 @@ class BinaryManagerTest(unittest.TestCase):
self.assertRaises(exceptions.InitializationError,
binary_manager.FetchPath, 'dep', 'plat', 'arch')
- @mock.patch(
- 'telemetry.internal.util.binary_manager.binary_manager.BinaryManager') # pylint: disable=line-too-long
- @mock.patch(
- 'telemetry.internal.util.binary_manager.base_config.BaseConfig')
+ @mock.patch('catapult_base.binary_manager.BinaryManager')
+ @mock.patch('dependency_manager.BaseConfig')
def testLocalPathInitialized(self, base_config_mock, binary_manager_mock):
base_config_mock.return_value = 'base_config_object'
expected = [mock.call.binary_manager.BinaryManager(
@@ -109,4 +101,3 @@ class BinaryManagerTest(unittest.TestCase):
def testLocalPathUninitialized(self):
self.assertRaises(exceptions.InitializationError,
binary_manager.LocalPath, 'dep', 'plat', 'arch')
-

Powered by Google App Engine
This is Rietveld 408576698