Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: dependency_manager/dependency_manager/manager.py

Issue 1838863002: Change telemetry run_tests.py to prefetch all binaries before tests in parallel (Closed) Base URL: https://github.com/catapult-project/catapult@master
Patch Set: Fix bug in DependencyManager.PrefetchPaths Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dependency_manager/dependency_manager/manager.py
diff --git a/dependency_manager/dependency_manager/manager.py b/dependency_manager/dependency_manager/manager.py
index d5fbf777b191f7e897f7ad797e7b627836d5eeed..f1a5c0f5e47ca36a28b82b53720ea69a66a7971f 100644
--- a/dependency_manager/dependency_manager/manager.py
+++ b/dependency_manager/dependency_manager/manager.py
@@ -152,9 +152,9 @@ class DependencyManager(object):
logging.error(
'Dependency %s could not be found or fetched from cloud storage for'
' platform %s.', dependency, platform)
- if missing_deps:
- raise exceptions.NoPathFoundError(', '.join(missing_deps), platform)
- return (found_deps, skipped_deps)
+ if missing_deps:
nednguyen 2016/03/29 03:14:05 Here is the bug
+ raise exceptions.NoPathFoundError(', '.join(missing_deps), platform)
+ return (found_deps, skipped_deps)
def _UpdateDependencies(self, config):
"""Add the dependency information stored in |config| to this instance.
« no previous file with comments | « dependency_manager/dependency_manager/__init__.py ('k') | telemetry/telemetry/internal/util/binary_manager.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698