catapult_base/catapult_base/cloud_storage.py - Issue 1838863002: Change telemetry run_tests.py to prefetch all binaries before tests in parallel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: catapult_base/catapult_base/cloud_storage.py

Issue 1838863002: Change telemetry run_tests.py to prefetch all binaries before tests in parallel (Closed) Base URL: https://github.com/catapult-project/catapult@master

Patch Set: Fix bug in DependencyManager.PrefetchPaths Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: catapult_base/catapult_base/cloud_storage.py

diff --git a/catapult_base/catapult_base/cloud_storage.py b/catapult_base/catapult_base/cloud_storage.py

index c7a6a0dde43f85d13d56ac4b829eff52be186d9a..b6ff87263b0fa4659a4957aae41a5b86d1bed1ef 100644

--- a/catapult_base/catapult_base/cloud_storage.py

+++ b/catapult_base/catapult_base/cloud_storage.py

@@ -134,7 +134,13 @@ def _RunCommand(args):

args = [_GSUTIL_PATH] + args

_EnsureExecutable(_GSUTIL_PATH)

- if (os.getenv(DISABLE_CLOUD_STORAGE_IO) == '1' and

+ disable_cloud_storage_env_val = os.getenv(DISABLE_CLOUD_STORAGE_IO)

+ if disable_cloud_storage_env_val and disable_cloud_storage_env_val != '1':

+ logging.error(

+ 'Unsupported value of environment variable '

+ 'DISABLE_CLOUD_STORAGE_IO. Expected None or \'1\' but got %s.',

+ disable_cloud_storage_env_val)

+ if (disable_cloud_storage_env_val == '1' and

args[0] not in ('help', 'hash', 'version')):

raise CloudStorageIODisabled(

"Environment variable DISABLE_CLOUD_STORAGE_IO is set to 1. "

« no previous file with comments | « no previous file | dependency_manager/dependency_manager/__init__.py » ('j') | dependency_manager/dependency_manager/manager.py » ('J')