server/internal/logdog/archivist/archivist_test.go - Issue 1838803002: LogDog: BigTable batching schema.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: server/internal/logdog/archivist/archivist_test.go

Issue 1838803002: LogDog: BigTable batching schema. (Closed) Base URL: https://github.com/luci/luci-go@recordio-split

Patch Set: Minor comments and quality of code tweaks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: server/internal/logdog/archivist/archivist_test.go

diff --git a/server/internal/logdog/archivist/archivist_test.go b/server/internal/logdog/archivist/archivist_test.go

index 413cceb07a12ca81c039914601463e291a911336..12daac169e7ca7d70f8181b69d077782b5ac5e8d 100644

--- a/server/internal/logdog/archivist/archivist_test.go

+++ b/server/internal/logdog/archivist/archivist_test.go

@@ -198,10 +198,10 @@ func TestHandleArchive(t *testing.T) {

panic(err)

}

- err = st.Put(&storage.PutRequest{

- Path: desc.Path(),

- Index: types.MessageIndex(v),

- Value: d,

+ err = st.Put(storage.PutRequest{

+ Path: desc.Path(),

+ Index: types.MessageIndex(v),

+ Values: [][]byte{d},

})

if err != nil {

panic(err)