server/internal/logdog/archivist/archivist.go - Issue 1838803002: LogDog: BigTable batching schema.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: server/internal/logdog/archivist/archivist.go

Issue 1838803002: LogDog: BigTable batching schema. (Closed) Base URL: https://github.com/luci/luci-go@recordio-split

Patch Set: Minor comments and quality of code tweaks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: server/internal/logdog/archivist/archivist.go

diff --git a/server/internal/logdog/archivist/archivist.go b/server/internal/logdog/archivist/archivist.go

index 925e053a039fed0f95f1e05812535f843ef627ee..1d79af1d0225532985066c380010d92f0ad693f4 100644

--- a/server/internal/logdog/archivist/archivist.go

+++ b/server/internal/logdog/archivist/archivist.go

@@ -355,7 +355,7 @@ func (s *storageSource) bufferEntries(start types.MessageIndex) error {

Path: s.path,

Index: start,

}

- return s.st.Get(&req, func(idx types.MessageIndex, d []byte) bool {

+ return s.st.Get(req, func(idx types.MessageIndex, d []byte) bool {

le := logpb.LogEntry{}

if err := proto.Unmarshal(d, &le); err != nil {

log.Fields{