common/proto/logdog/svcconfig/config.proto - Issue 1838803002: LogDog: BigTable batching schema.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: common/proto/logdog/svcconfig/config.proto

Issue 1838803002: LogDog: BigTable batching schema. (Closed) Base URL: https://github.com/luci/luci-go@recordio-split

Patch Set: Minor comments and quality of code tweaks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: common/proto/logdog/svcconfig/config.proto

diff --git a/common/proto/logdog/svcconfig/config.proto b/common/proto/logdog/svcconfig/config.proto

index 806f7c12cb3d5223b6b2231ee34a4f82641bfed1..20ee85005a0090ff7e799cb7fd4d0d0e29da23a6 100644

--- a/common/proto/logdog/svcconfig/config.proto

+++ b/common/proto/logdog/svcconfig/config.proto

@@ -71,11 +71,13 @@ message Coordinator {

// Collector is the set of configuration parameters for Collector instances.

message Collector {

- // Workers is the number of ingest workers to run.

- int32 workers = 1;

+ // The maximum number of concurrent transport messages to process. If <= 0,

+ // a default will be chosen based on the transport.

+ int32 max_concurrent_messages = 1;

- // The number of transport worker goroutines to run.

- int32 transport_workers = 2;

+ // The maximum number of concurrent workers to process each ingested message.

+ // If <= 0, collector.DefaultMaxMessageWorkers will be used.

+ int32 max_message_workers = 2;

// The maximum number of log stream states to cache locally. If <= 0, a

// default will be used.

« no previous file with comments | « common/proto/logdog/logpb/butler.pb.go ('k') | common/proto/logdog/svcconfig/config.pb.go » ('j') | no next file with comments »