common/proto/logdog/logpb/butler.pb.go - Issue 1838803002: LogDog: BigTable batching schema.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: common/proto/logdog/logpb/butler.pb.go

Issue 1838803002: LogDog: BigTable batching schema. (Closed) Base URL: https://github.com/luci/luci-go@recordio-split

Patch Set: Minor comments and quality of code tweaks. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: common/proto/logdog/logpb/butler.pb.go

diff --git a/common/proto/logdog/logpb/butler.pb.go b/common/proto/logdog/logpb/butler.pb.go

index d17437816f83e9d99d153b7e3fc037398eff290b..421afbdfa8f42632e12c0d80ab587f125a494d3a 100644

--- a/common/proto/logdog/logpb/butler.pb.go

+++ b/common/proto/logdog/logpb/butler.pb.go

@@ -189,8 +189,7 @@ type ButlerLogBundle_Entry struct {

// message index in the stream.

TerminalIndex uint64 `protobuf:"varint,4,opt,name=terminal_index" json:"terminal_index,omitempty"`

- // Log entries attached to this record. These must be sequential and in

- // order.

+ // Log entries attached to this record. These MUST be sequential.

// This is the main log entry content.

Logs []*LogEntry `protobuf:"bytes,5,rep,name=logs" json:"logs,omitempty"`

« no previous file with comments | « common/proto/logdog/logpb/butler.proto ('k') | common/proto/logdog/svcconfig/config.proto » ('j') | no next file with comments »