[DevTools] Debugger::currentCallFrames returns array instead linked list

[DevTools] Debugger::currentCallFrames returns array instead linked list

We can return array instead linked list since V8JavaScriptCallFrame wrapper was removed.
Method callFrameByIndex was removed because we can use currentCallFrames instead: cached when DevTools is paused and with getter when we check stack trace for DOM breakpoint.

BUG=595206
R=dgozman@chromium.org

Committed: https://crrev.com/e87c79ce6ef4baa6e78b3eb8d9d7627a89a44885
Cr-Commit-Position: refs/heads/master@{#383448}

[kozy, 2016-03-26 00:14:12]

Dmitry, please take a look!

[dgozman, 2016-03-26 00:49:21]

https://codereview.chromium.org/1838683002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1838683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:488:
m_currentCallFrames = debugger().currentCallFrames();
m_pausedCallFrames

https://codereview.chromium.org/1838683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:506:
bool V8DebuggerAgentImpl::isTopCallFrameBlackboxed()
isTopPausedFrameBlackboxed

https://codereview.chromium.org/1838683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1490:
return RequestContinue;
This is a semantic change.

https://codereview.chromium.org/1838683002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp (right):

https://codereview.chromium.org/1838683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:472: return
callFrames;
Let's be explicit.

https://codereview.chromium.org/1838683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:483: return
callFrames;
Let's be explicit.

[kozy, 2016-03-26 01:11:17]

All done!

https://codereview.chromium.org/1838683002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1838683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:488:
m_currentCallFrames = debugger().currentCallFrames();
On 2016/03/26 00:49:20, dgozman wrote:
> m_pausedCallFrames

Done.

https://codereview.chromium.org/1838683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:506:
bool V8DebuggerAgentImpl::isTopCallFrameBlackboxed()
On 2016/03/26 00:49:21, dgozman wrote:
> isTopPausedFrameBlackboxed

Done.

https://codereview.chromium.org/1838683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1490:
return RequestContinue;
On 2016/03/26 00:49:20, dgozman wrote:
> This is a semantic change.

Reverted.

https://codereview.chromium.org/1838683002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp (right):

https://codereview.chromium.org/1838683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:472: return
callFrames;
On 2016/03/26 00:49:21, dgozman wrote:
> Let's be explicit.

Done.

https://codereview.chromium.org/1838683002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:483: return
callFrames;
On 2016/03/26 00:49:21, dgozman wrote:
> Let's be explicit.

Done.

[dgozman, 2016-03-26 01:48:24]

https://codereview.chromium.org/1838683002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1838683002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:512:
bool V8DebuggerAgentImpl::isCallFrameBlackboxed(JavaScriptCallFrame* callFrame)
This is redundant.

https://codereview.chromium.org/1838683002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1367:
for (size_t i = 0; i < m_pausedCallFrames.size(); ++i) {
i -> frameOrdinal

https://codereview.chromium.org/1838683002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1508: if
(!topCallFrame)
Move this back.

https://codereview.chromium.org/1838683002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp (right):

https://codereview.chromium.org/1838683002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:482: return
Vector<OwnPtr<JavaScriptCallFrame>>();
Let's introduce JavaScriptCallFrames type.

[kozy, 2016-03-26 02:00:42]

All done!

https://codereview.chromium.org/1838683002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1838683002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:512:
bool V8DebuggerAgentImpl::isCallFrameBlackboxed(JavaScriptCallFrame* callFrame)
On 2016/03/26 01:48:24, dgozman wrote:
> This is redundant.

Removed.

https://codereview.chromium.org/1838683002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1367:
for (size_t i = 0; i < m_pausedCallFrames.size(); ++i) {
On 2016/03/26 01:48:24, dgozman wrote:
> i -> frameOrdinal

Done.

https://codereview.chromium.org/1838683002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp:1508: if
(!topCallFrame)
On 2016/03/26 01:48:24, dgozman wrote:
> Move this back.

Done.

https://codereview.chromium.org/1838683002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp (right):

https://codereview.chromium.org/1838683002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp:482: return
Vector<OwnPtr<JavaScriptCallFrame>>();
On 2016/03/26 01:48:24, dgozman wrote:
> Let's introduce JavaScriptCallFrames type.

Done.

[dgozman, 2016-03-26 02:20:24]

lgtm

https://codereview.chromium.org/1838683002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h
(right):

https://codereview.chromium.org/1838683002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h:71:
typedef Vector<OwnPtr<JavaScriptCallFrame>> JavaScriptCallFrames;
style: using Type = Definition;

https://codereview.chromium.org/1838683002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
(right):

https://codereview.chromium.org/1838683002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h:228:
Vector<OwnPtr<JavaScriptCallFrame>> m_pausedCallFrames;
JavaScriptCallFrames

[kozy, 2016-03-26 02:22:14]

All done!

https://codereview.chromium.org/1838683002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h
(right):

https://codereview.chromium.org/1838683002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h:71:
typedef Vector<OwnPtr<JavaScriptCallFrame>> JavaScriptCallFrames;
On 2016/03/26 02:20:23, dgozman wrote:
> style: using Type = Definition;

Done.

https://codereview.chromium.org/1838683002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
(right):

https://codereview.chromium.org/1838683002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h:228:
Vector<OwnPtr<JavaScriptCallFrame>> m_pausedCallFrames;
On 2016/03/26 02:20:23, dgozman wrote:
> JavaScriptCallFrames

Done.

[kozy, 2016-03-26 02:22:18]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-03-26 02:22:18]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1838683002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-03-26 02:22:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838683002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838683002/80001

[commit-bot: I haz the power, 2016-03-26 05:48:19]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-26 05:50:10]

Description was changed from

==========
[DevTools] Debugger::currentCallFrames returns array instead linked list

We can return array instead linked list since V8JavaScriptCallFrame wrapper was
removed.
Method callFrameByIndex was removed because we can use currentCallFrames
instead: cached when DevTools is paused and with getter when we check stack
trace for DOM breakpoint.

BUG=595206
R=dgozman@chromium.org
==========

to

==========
[DevTools] Debugger::currentCallFrames returns array instead linked list

We can return array instead linked list since V8JavaScriptCallFrame wrapper was
removed.
Method callFrameByIndex was removed because we can use currentCallFrames
instead: cached when DevTools is paused and with getter when we check stack
trace for DOM breakpoint.

BUG=595206
R=dgozman@chromium.org

Committed: https://crrev.com/e87c79ce6ef4baa6e78b3eb8d9d7627a89a44885
Cr-Commit-Position: refs/heads/master@{#383448}
==========

[commit-bot: I haz the power, 2016-03-26 05:50:11]

Patchset 5 (id:??) landed as
https://crrev.com/e87c79ce6ef4baa6e78b3eb8d9d7627a89a44885
Cr-Commit-Position: refs/heads/master@{#383448}