third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp - Issue 1838683002: [DevTools] Debugger::currentCallFrames returns array instead linked list

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp

Issue 1838683002: [DevTools] Debugger::currentCallFrames returns array instead linked list (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wrap-with-corrrect-injected-script

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp b/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp

index 59b292a0f67e3f4ed7f9b09d597a50bfbc610b48..5c216f62a3819dc5df81de3c80f1c9a43008fb89 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp

@@ -47,16 +47,6 @@ JavaScriptCallFrame::~JavaScriptCallFrame()

{

}

-PassOwnPtr<JavaScriptCallFrame> JavaScriptCallFrame::caller()

- v8::HandleScope handleScope(m_isolate);

- v8::Local<v8::Context> debuggerContext = v8::Local<v8::Context>::New(m_isolate, m_debuggerContext);

- v8::Local<v8::Value> callerFrame = v8::Local<v8::Object>::New(m_isolate, m_callFrame)->Get(toV8StringInternalized(m_isolate, "caller"));

- if (callerFrame.IsEmpty() || !callerFrame->IsObject())

- return 0;

- return JavaScriptCallFrame::create(debuggerContext, v8::Local<v8::Object>::Cast(callerFrame));

int JavaScriptCallFrame::callV8FunctionReturnInt(const char* name) const

{

v8::HandleScope handleScope(m_isolate);