[MD settings] touch up sub-page titles and icons

[MD settings] touch up sub-page titles and icons

This CL adjusts the back-arrow and title of settings
sup-pages.  It also removes the stroke style from
icons used in settings.

BUG=597860, 597884
Committed: https://crrev.com/66961d30ae4eefe091c94f3910819904bb721bb6
Cr-Commit-Position: refs/heads/master@{#383349}

[dschuyler, 2016-03-25 18:24:33]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[dschuyler, 2016-03-25 18:24:34]

There is a screen shot at: imgur.com/S6V7Fh5

[dpapad, 2016-03-25 18:31:07]

https://codereview.chromium.org/1838533002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/settings_subheader.html
(right):

https://codereview.chromium.org/1838533002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/settings_subheader.html:19: h2 {
Can we merge the contents of settings_subheader.css into this inline CSS <style>
tag?

Asking because settings_subheader.css also has an h2 selector, so it is a bit
confusing to spread some  inline and some in a separate file.

[dschuyler, 2016-03-25 19:18:08]

Patchset #2 (id:20001) has been deleted

[dschuyler, 2016-03-25 19:18:54]

https://codereview.chromium.org/1838533002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/settings_subheader.html
(right):

https://codereview.chromium.org/1838533002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/settings_subheader.html:19: h2 {
On 2016/03/25 18:31:07, dpapad wrote:
> Can we merge the contents of settings_subheader.css into this inline CSS
<style>
> tag?
> 
> Asking because settings_subheader.css also has an h2 selector, so it is a bit
> confusing to spread some  inline and some in a separate file.

That file can be removed, actually.

Done.

[dpapad, 2016-03-25 19:25:58]

https://codereview.chromium.org/1838533002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/settings_subheader.html
(right):

https://codereview.chromium.org/1838533002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/settings_subheader.html:6: <link
rel="import" type="css" href="settings_subheader.css">
This line needs to be removed now.

[dschuyler, 2016-03-25 20:24:46]

https://codereview.chromium.org/1838533002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_page/settings_subheader.html
(right):

https://codereview.chromium.org/1838533002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/settings_page/settings_subheader.html:6: <link
rel="import" type="css" href="settings_subheader.css">
On 2016/03/25 19:25:58, dpapad wrote:
> This line needs to be removed now.

Done.

[dpapad, 2016-03-25 20:28:56]

lgtm

[dschuyler, 2016-03-25 20:31:03]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-03-25 20:31:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838533002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838533002/60001

[commit-bot: I haz the power, 2016-03-25 20:38:22]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-03-25 20:40:13]

Description was changed from

==========
[MD settings] touch up sub-page titles and icons

This CL adjusts the back-arrow and title of settings
sup-pages.  It also removes the stroke style from
icons used in settings.

BUG=597860, 597884
==========

to

==========
[MD settings] touch up sub-page titles and icons

This CL adjusts the back-arrow and title of settings
sup-pages.  It also removes the stroke style from
icons used in settings.

BUG=597860, 597884

Committed: https://crrev.com/66961d30ae4eefe091c94f3910819904bb721bb6
Cr-Commit-Position: refs/heads/master@{#383349}
==========

[commit-bot: I haz the power, 2016-03-25 20:40:14]

Patchset 3 (id:??) landed as
https://crrev.com/66961d30ae4eefe091c94f3910819904bb721bb6
Cr-Commit-Position: refs/heads/master@{#383349}