chrome/browser/resources/settings/settings_page/settings_subheader.html - Issue 1838533002: [MD settings] touch up sub-page titles and icons

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings_page/settings_subheader.html

Issue 1838533002: [MD settings] touch up sub-page titles and icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_menu/settings_menu.html ('k') | chrome/browser/resources/settings/settings_shared_css.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/html/polymer.html">	1 <link rel="import" href="chrome://resources/html/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">

3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml">	3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.h tml">

	4 <link rel="import" href="chrome://md-settings/settings_shared_css.html">

4	5

5 <dom-module id="settings-subheader">	6 <dom-module id="settings-subheader">

6 <link rel="import" type="css" href="settings_subheader.css">	7 <link rel="import" type="css" href="settings_subheader.css">

7 <template>	8 <template>

8 <paper-icon-button icon="arrow-back" on-tap="onTapBack_">	9 <style include="settings-shared">

9 </paper-icon-button>	10 :root {

10 <h2>[[pageTitle]]</h2>	11 --iron-icon-fill-color: var(--settings-side-nav-color);

	12 --paper-icon-button: {

	13 width: 36px;

	14 height: 36px;

	15 margin: 0 12px 0 -8px;

	16 }

	17 }

	18

	19 h2 {
	dpapad 2016/03/25 18:31:07 Can we merge the contents of settings_subheader.cs Can we merge the contents of settings_subheader.css into this inline CSS <style> tag? Asking because settings_subheader.css also has an h2 selector, so it is a bit confusing to spread some inline and some in a separate file. dschuyler 2016/03/25 19:18:54 That file can be removed, actually. Done. Show quoted text On 2016/03/25 18:31:07, dpapad wrote: > Can we merge the contents of settings_subheader.css into this inline CSS <style> > tag? > > Asking because settings_subheader.css also has an h2 selector, so it is a bit > confusing to spread some inline and some in a separate file. That file can be removed, actually. Done.
	20 color: var(--settings-side-nav-color);

	21 font-size: 107.6923%;

	22 }

	23 </style>

	24 <div class="settings-box first">

	25 <paper-icon-button icon="arrow-back" on-tap="onTapBack_">

	26 </paper-icon-button>

	27 <h2>[[pageTitle]]</h2>

	28 </div>

11 </template>	29 </template>

12 <script src="settings_subheader.js"></script>	30 <script src="settings_subheader.js"></script>

13 </dom-module>	31 </dom-module>

OLD	NEW