Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 183853038: Revert 168568 "Remove unneeded destructors and add finalization ..." (Closed)

Created:
6 years, 9 months ago by haraken
Modified:
6 years, 9 months ago
Reviewers:
zerny-chromium
CC:
blink-reviews
Visibility:
Public.

Description

Revert 168568 "Remove unneeded destructors and add finalization ..." This CL broke oilpan Debug builds with clang. > ../../third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp > 1. <eof> parser at end of file > 2. Per-file LLVM IR generation > 3. ../../third_party/WebKit/Source/heap/Heap.h:904:10: Generating code for > declaration > 'WebCore::GarbageCollectedFinalized<WebCore::CSSCalcExpressionNode>::finalize' > clang: error: unable to execute command: Aborted (core dumped) > clang: error: clang frontend command failed due to signal (use -v to see > invocation) > Remove unneeded destructors and add finalization support to various classes. > > Issues reported by the Blink GC clang plugin. > > R=haraken@chromium.org > BUG= > > Review URL: https://codereview.chromium.org/184853006 TBR=zerny@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168581

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M trunk/Source/core/css/CSSCalculationValue.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/core/plugins/DOMPluginArray.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/modules/gamepad/GamepadList.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/modules/speech/SpeechRecognitionResult.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
haraken
6 years, 9 months ago (2014-03-06 07:36:24 UTC) #1
haraken
Committed patchset #1 manually as r168581.
6 years, 9 months ago (2014-03-06 07:36:46 UTC) #2
zerny-chromium
Thanks. Fix for relanding in https://codereview.chromium.org/188473004
6 years, 9 months ago (2014-03-06 10:50:44 UTC) #3
zerny-chromium
6 years, 9 months ago (2014-03-06 10:50:56 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698