Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 188473004: Reapply r168568 "Remove unneeded destructors and add finalization support to various classes." (Closed)

Created:
6 years, 9 months ago by zerny-chromium
Modified:
6 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, oilpan-reviews
Visibility:
Public.

Description

Reapply r168568 "Remove unneeded destructors and add finalization support to various classes." The previous CL (https://codereview.chromium.org/184853006) caused a clang crash (http://llvm.org/bugs/show_bug.cgi?id=16220). The issue is resolved by placing the implementation of the pure-virtual destructor in the header file. This CL also makes the destructor non-pure because the CSSCalcExpressionNode has other pure-virtuals. R=haraken@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M Source/core/css/CSSCalculationValue.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSCalculationValue.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/plugins/DOMPluginArray.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/gamepad/GamepadList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionResult.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (0 generated)
zerny-chromium
6 years, 9 months ago (2014-03-06 10:51:14 UTC) #1
haraken
LGTM
6 years, 9 months ago (2014-03-06 10:52:12 UTC) #2
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 9 months ago (2014-03-06 11:19:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/188473004/1
6 years, 9 months ago (2014-03-06 11:19:56 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 11:21:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel
6 years, 9 months ago (2014-03-06 11:21:16 UTC) #6
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 9 months ago (2014-03-06 11:32:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/188473004/1
6 years, 9 months ago (2014-03-06 11:32:40 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 12:17:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-06 12:17:17 UTC) #10
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 9 months ago (2014-03-06 13:19:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/188473004/1
6 years, 9 months ago (2014-03-06 13:19:34 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 13:38:51 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-06 13:38:52 UTC) #14
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 9 months ago (2014-03-06 15:04:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/188473004/1
6 years, 9 months ago (2014-03-06 15:04:20 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 15:08:18 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-06 15:08:19 UTC) #18
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 9 months ago (2014-03-07 07:00:59 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/188473004/20001
6 years, 9 months ago (2014-03-07 07:01:16 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 07:45:39 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel
6 years, 9 months ago (2014-03-07 07:45:39 UTC) #22
zerny-chromium
6 years, 9 months ago (2014-03-11 11:42:18 UTC) #23
I'm going to abandon this change and merge it into
https://codereview.chromium.org/189543014/

Powered by Google App Engine
This is Rietveld 408576698