Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 183853028: Add a histogram to track the number of QUIC packets received by a QUIC (Closed)

Created:
6 years, 9 months ago by Ryan Hamilton
Modified:
6 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Add a histogram to track the number of QUIC packets received by a QUIC connection whose handshake was not confirmed when that connection is closed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255783

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M net/quic/quic_stream_factory.cc View 1 2 chunks +10 lines, -7 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Ryan Hamilton
6 years, 9 months ago (2014-03-04 23:07:26 UTC) #1
Ryan Hamilton
On 2014/03/04 23:07:26, Ryan Hamilton wrote: ping
6 years, 9 months ago (2014-03-06 05:17:11 UTC) #2
jar (doing other things)
LGTM % nit https://codereview.chromium.org/183853028/diff/1/net/quic/quic_stream_factory.cc File net/quic/quic_stream_factory.cc (right): https://codereview.chromium.org/183853028/diff/1/net/quic/quic_stream_factory.cc#newcode447 net/quic/quic_stream_factory.cc:447: QuicConnectionStats stats = session->connection()->GetStats(); nit: Can ...
6 years, 9 months ago (2014-03-06 22:28:25 UTC) #3
Ryan Hamilton
Thanks. https://codereview.chromium.org/183853028/diff/1/net/quic/quic_stream_factory.cc File net/quic/quic_stream_factory.cc (right): https://codereview.chromium.org/183853028/diff/1/net/quic/quic_stream_factory.cc#newcode447 net/quic/quic_stream_factory.cc:447: QuicConnectionStats stats = session->connection()->GetStats(); On 2014/03/06 22:28:25, jar ...
6 years, 9 months ago (2014-03-06 22:42:58 UTC) #4
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 9 months ago (2014-03-06 22:43:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/183853028/20001
6 years, 9 months ago (2014-03-06 22:50:18 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 00:34:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-07 00:34:27 UTC) #8
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 9 months ago (2014-03-08 14:38:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/183853028/20001
6 years, 9 months ago (2014-03-08 14:38:34 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-08 18:00:03 UTC) #11
Message was sent while issue was closed.
Change committed as 255783

Powered by Google App Engine
This is Rietveld 408576698