Add a histogram to track the number of QUIC packets received by a QUIC

net/quic/quic_stream_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_stream_factory.h"
 
 #include <set>
 
 #include "base/message_loop/message_loop.h"
 #include "base/message_loop/message_loop_proxy.h"
@@ skipping 407 matching lines @@
   QuicClientSession* session = active_sessions_[host_port_proxy_pair];
   DCHECK(session);
   return scoped_ptr<QuicHttpStream>(
       new QuicHttpStream(session->GetWeakPtr()));
 }
 
 void QuicStreamFactory::OnIdleSession(QuicClientSession* session) {
 }
 
 void QuicStreamFactory::OnSessionGoingAway(QuicClientSession* session) {
+  const QuicConnectionStats& stats = session->connection()->GetStats();
   const AliasSet& aliases = session_aliases_[session];
   for (AliasSet::const_iterator it = aliases.begin(); it != aliases.end();
        ++it) {
     DCHECK(active_sessions_.count(*it));
     DCHECK_EQ(session, active_sessions_[*it]);
     active_sessions_.erase(*it);
     if (!http_server_properties_)
       continue;
 
     if (!session->IsCryptoHandshakeConfirmed()) {
       // TODO(rch):  In the special case where the session has received no
       // packets from the peer, we should consider blacklisting this
       // differently so that we still race TCP but we don't consider the
       // session connected until the handshake has been confirmed.
       http_server_properties_->SetBrokenAlternateProtocol(it->first);
+      UMA_HISTOGRAM_COUNTS("Net.QuicHandshakeNotConfirmedNumPacketsReceived",
+                           stats.packets_received);
     } else {
       QuicConnectionStats stats = session->connection()->GetStats();

[jar (doing other things), 2014/03/06 22:28:25]

nit: Can we delete this since you pulled it out of the loop to common code?

[Ryan Hamilton, 2014/03/06 22:42:58]

Done.  Also added a continue to the previous block, and removed the else.

       HttpServerProperties::NetworkStats network_stats;
       network_stats.rtt = base::TimeDelta::FromMicroseconds(stats.rtt);
       network_stats.bandwidth_estimate = stats.estimated_bandwidth;
       http_server_properties_->SetServerNetworkStats(
           it->first, network_stats);
     }
   }
   IPEndPoint peer_address = session->connection()->peer_address();
   ip_aliases_[peer_address].erase(session);
   if (ip_aliases_[peer_address].empty()) {
@@ skipping 230 matching lines @@
   // Copy the CachedState for the canonical server from canonical_crypto_config
   // as the initial CachedState for the server_hostname in crypto_config.
   crypto_config->InitializeFrom(server_hostname,
                                 canonical_host_port_proxy_pair.first.host(),
                                 canonical_crypto_config);
   // Update canonical version to point at the "most recent" crypto_config.
   canonical_hostname_to_origin_map_[canonical_host_port] = host_port_proxy_pair;
 }
 
 }  // namespace net