Issue 183853004: When upgrading the test data twice, don't bail out because of an existing backup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 183853004: When upgrading the test data twice, don't bail out because of an existing backup (Closed)

Created:
6 years, 9 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

When upgrading the test data twice, don't bail out because of an existing backup BUG=none R=jkummerow@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=19605

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	test/mozilla/testcfg.py	View		1 chunk	+4 lines, -1 line	1 comment	Download
	M	test/test262/testcfg.py	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with comment. https://codereview.chromium.org/183853004/diff/1/test/mozilla/testcfg.py File test/mozilla/testcfg.py (right): https://codereview.chromium.org/183853004/diff/1/test/mozilla/testcfg.py#newcode138 test/mozilla/testcfg.py:138: shutil.rmtree(directory_old_name) s/directory_old_name/directory_name_old/ !

6 years, 9 months ago (2014-02-28 12:27:10 UTC) #2

jochen (gone - plz use gerrit)

6 years, 9 months ago (2014-02-28 12:33:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19605 (tree was closed).

Expand Messages | Collapse Messages