test/mozilla/testcfg.py - Issue 183853004: When upgrading the test data twice, don't bail out because of an existing backup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/mozilla/testcfg.py

Issue 183853004: When upgrading the test data twice, don't bail out because of an existing backup (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/mozilla/testcfg.py

diff --git a/test/mozilla/testcfg.py b/test/mozilla/testcfg.py

index 775a239f07d186655d8efcb09f1ecd118324f01b..e0558267a57d9c0f0b3f4eba035ead1711db10b8 100644

--- a/test/mozilla/testcfg.py

+++ b/test/mozilla/testcfg.py

@@ -132,8 +132,11 @@ class MozillaTestSuite(testsuite.TestSuite):

# If we have a local archive file with the test data, extract it.

directory_name = "data"

+ directory_name_old = "data.old"

if os.path.exists(directory_name):

- os.rename(directory_name, "data.old")

+ if os.path.exists(directory_name_old):

+ shutil.rmtree(directory_old_name)

Jakob Kummerow 2014/02/28 12:27:10 s/directory_old_name/directory_name_old/ !

+ os.rename(directory_name, directory_name_old)

archive_file = "downloaded_%s.tar.gz" % MOZILLA_VERSION

if os.path.exists(archive_file):

with tarfile.open(archive_file, "r:gz") as tar:

« no previous file with comments | « no previous file | test/test262/testcfg.py » ('j') | no next file with comments »