Issue 1838493002: Fix building gpu twice in gn component build

Issue 1838493002: Fix building gpu twice in gn component build (Closed)

Created:
4 years, 9 months ago by boliu

Modified:
4 years, 9 months ago

Reviewers:
brettw

CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix building gpu twice in gn component build Fix for https://codereview.chromium.org/1745903002/ BUG=597958 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -4 lines)			Patch
M	content/public/gpu/BUILD.gn	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gpu/config/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 9 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838493002/1

4 years, 9 months ago (2016-03-25 17:33:49 UTC) #3

boliu

4 years, 9 months ago (2016-03-25 18:29:29 UTC) #9

Message was sent while issue was closed.

On 2016/03/25 18:28:23, brettw wrote:
> Thanks! LGTM

You already reverted the original CL :)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages