Use shared MockSdk instances in resynthesize tests.

Use shared MockSdk instances in resynthesize tests.

This restores tests performance mostly to where it was before, modulo
additional time for a new UnlinkedSummarizeAstTest set of tests.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/0dfa93772effe91809651d930e070ea015fc6aca

[Paul Berry, 2016-03-25 16:42:33]

lgtm

[scheglov, 2016-03-25 17:22:29]

Description was changed from

==========
Use shared MockSdk instances in resynthesize tests.

This restores tests performance mostly to where it was before, modulo
additional time for a new UnlinkedSummarizeAstTest set of tests.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Use shared MockSdk instances in resynthesize tests.

This restores tests performance mostly to where it was before, modulo
additional time for a new UnlinkedSummarizeAstTest set of tests.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/0dfa93772effe91809651d930e070ea015fc6aca
==========

[scheglov, 2016-03-25 17:22:30]

Committed patchset #1 (id:1) manually as
0dfa93772effe91809651d930e070ea015fc6aca (presubmit successful).

[Brian Wilkerson, 2016-03-28 16:58:03]

https://codereview.chromium.org/1838453002/diff/1/pkg/analyzer/test/src/conte...
File pkg/analyzer/test/src/context/abstract_context.dart (right):

https://codereview.chromium.org/1838453002/diff/1/pkg/analyzer/test/src/conte...
pkg/analyzer/test/src/context/abstract_context.dart:126: DartSdk createDartSdk()
=> new MockSdk();
It seems strange to create a new SDK when we have two created above.

https://codereview.chromium.org/1838453002/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/dart_test.dart (right):

https://codereview.chromium.org/1838453002/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/dart_test.dart:1079: DartSdk createDartSdk() => new
MockSdk(dartAsync: false);
Should this be a constant?

[scheglov, 2016-03-28 17:03:35]

https://codereview.chromium.org/1838453002/diff/1/pkg/analyzer/test/src/conte...
File pkg/analyzer/test/src/context/abstract_context.dart (right):

https://codereview.chromium.org/1838453002/diff/1/pkg/analyzer/test/src/conte...
pkg/analyzer/test/src/context/abstract_context.dart:126: DartSdk createDartSdk()
=> new MockSdk();
On 2016/03/28 16:58:03, Brian Wilkerson wrote:
> It seems strange to create a new SDK when we have two created above.

My intention is to test SDK analysis from scratch in every Dart analysis task
test.
OTOH when we're outside of dart.dart tests, we can opt-in to using a shared SDK.