Use shared MockSdk instances in resynthesize tests.

pkg/analyzer/test/src/context/abstract_context.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.test.src.context.abstract_context;
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/dart/element/visitor.dart';
 import 'package:analyzer/file_system/file_system.dart';
@@ skipping 27 matching lines @@
   }));
   return result;
 }
 
 /**
  * A function to be called for every [Element].
  */
 typedef void _ElementVisitorFunction(Element element);
 
 class AbstractContextTest {
+  static final MockSdk SHARED_MOCK_SDK = new MockSdk();
+  static final MockSdk SHARED_STRONG_MOCK_SDK = new MockSdk();
+
   MemoryResourceProvider resourceProvider = new MemoryResourceProvider();
 
-  DartSdk sdk = new MockSdk();
+  DartSdk sdk;
   SourceFactory sourceFactory;
   AnalysisContextImpl context;
   AnalysisCache analysisCache;
   AnalysisDriver analysisDriver;
 
   UriResolver sdkResolver;
   UriResolver resourceResolver;
 
   AnalysisTask task;
   Map<ResultDescriptor<dynamic>, dynamic> oldOutputs;
@@ skipping 52 matching lines @@
     outputs = task.outputs;
     for (ResultDescriptor descriptor in task.descriptor.results) {
       expect(outputs, contains(descriptor));
     }
   }
 
   AnalysisContextImpl createAnalysisContext() {
     return new AnalysisContextImpl();
   }
 
+  DartSdk createDartSdk() => new MockSdk();

[Brian Wilkerson, 2016/03/28 16:58:03]

It seems strange to create a new SDK when we have two created above.

[scheglov, 2016/03/28 17:03:35]

My intention is to test SDK analysis from scratch in every Dart analysis task
test.
OTOH when we're outside of dart.dart tests, we can opt-in to using a shared SDK.

+
   Source newSource(String path, [String content = '']) {
     File file = resourceProvider.newFile(path, content);
     return file.createSource();
   }
 
   List<Source> newSources(Map<String, String> sourceMap) {
     List<Source> sources = <Source>[];
     sourceMap.forEach((String path, String content) {
       Source source = newSource(path, content);
       sources.add(source);
     });
     return sources;
   }
 
   void prepareAnalysisContext([AnalysisOptions options]) {
+    sdk = createDartSdk();
     sdkResolver = new DartUriResolver(sdk);
     resourceResolver = new ResourceUriResolver(resourceProvider);
     sourceFactory =
         new SourceFactory(<UriResolver>[sdkResolver, resourceResolver]);
     context = createAnalysisContext();
     if (options != null) {
       context.analysisOptions = options;
     }
     context.sourceFactory = sourceFactory;
     analysisCache = context.analysisCache;
@@ skipping 26 matching lines @@
 class _ElementVisitorFunctionWrapper extends GeneralizingElementVisitor {
   final _ElementVisitorFunction function;
 
   _ElementVisitorFunctionWrapper(this.function);
 
   visitElement(Element element) {
     function(element);
     super.visitElement(element);
   }
 }