Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 183833014: Properly handle a NULL webwidget returned from WebViewClient::createPopupMenu (Closed)

Created:
6 years, 9 months ago by adamk
Modified:
6 years, 9 months ago
Reviewers:
jamesr
CC:
blink-reviews
Visibility:
Public.

Description

Properly handle a NULL webwidget returned from WebViewClient::createPopupMenu The code path resulting in a NULL here currently segfaults, but will return NULL after the Chromium-side patch https://codereview.chromium.org/185653006/ BUG=347901 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168395

Patch Set 1 : Upload again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/web/PopupContainer.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
adamk
Not sure how to write a test for this...
6 years, 9 months ago (2014-03-03 19:27:53 UTC) #1
jamesr
lgtm
6 years, 9 months ago (2014-03-03 20:17:39 UTC) #2
adamk
The CQ bit was checked by adamk@chromium.org
6 years, 9 months ago (2014-03-03 20:29:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/183833014/20001
6 years, 9 months ago (2014-03-03 20:30:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/183833014/20001
6 years, 9 months ago (2014-03-03 23:20:50 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 14:08:41 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=25432
6 years, 9 months ago (2014-03-04 14:08:41 UTC) #7
adamk
The CQ bit was checked by adamk@chromium.org
6 years, 9 months ago (2014-03-04 17:13:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/183833014/20001
6 years, 9 months ago (2014-03-04 17:14:12 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 17:14:30 UTC) #10
Message was sent while issue was closed.
Change committed as 168395

Powered by Google App Engine
This is Rietveld 408576698