Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2186)

Unified Diff: Source/web/PopupContainer.cpp

Issue 183833014: Properly handle a NULL webwidget returned from WebViewClient::createPopupMenu (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Upload again Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/PopupContainer.cpp
diff --git a/Source/web/PopupContainer.cpp b/Source/web/PopupContainer.cpp
index 566d1fe73493f94d9ddf4968082c6f8226f5c308..f9c3e51c0dce554beb396faa77a33a83c1fa8987 100644
--- a/Source/web/PopupContainer.cpp
+++ b/Source/web/PopupContainer.cpp
@@ -472,6 +472,8 @@ void PopupContainer::popupOpened(const IntRect& bounds)
return;
WebWidget* webwidget = webView->client()->createPopupMenu(WebPopupTypeSelect);
+ if (!webwidget)
+ return;
// We only notify when the WebView has to handle the popup, as when
// the popup is handled externally, the fact that a popup is showing is
// transparent to the WebView.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698