src/full-codegen/x64/full-codegen-x64.cc - Issue 1838283003: Migrate FastCloneShallowObjectStub to TurboFan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 1838283003: Migrate FastCloneShallowObjectStub to TurboFan (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/x64/full-codegen-x64.cc

diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc

index 560239eda9bfb88a4c02b77d8624a452b9149412..dfa41c1fc8427d6c7b179dfbaaeef15079e9b24c 100644

--- a/src/full-codegen/x64/full-codegen-x64.cc

+++ b/src/full-codegen/x64/full-codegen-x64.cc

@@ -1380,8 +1380,10 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {

__ Move(rbx, Smi::FromInt(expr->literal_index()));

__ Move(rcx, constant_properties);

__ Move(rdx, Smi::FromInt(flags));

+ __ Push(rsi);

FastCloneShallowObjectStub stub(isolate(), expr->properties_count());

__ CallStub(&stub);

+ __ Pop(rsi);

Benedikt Meurer 2016/04/06 17:20:36 No need to push/pop the context, just reload it fr

}

PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG);