Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1838183002: [Password Manager] Prefetch blacklisted Android credentials in AffiliatedMatchHelper's initializatio (Closed)

Created:
4 years, 8 months ago by kolos1
Modified:
4 years, 8 months ago
Reviewers:
engedy
CC:
chromium-reviews, qsr+mojo_chromium.org, media-router+watch_chromium.org, Aaron Boodman, posciak+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, viettrungluu+watch_chromium.org, mcasas+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@android_credentials_blacklisted
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password Manager] Prefetch blacklisted Android credentials in AffiliatedMatchHelper's initialization Before this CL, only autofillable logins were prefetched. BUG=597574 Committed: https://crrev.com/d12aeb8306eaf1df7259b8a5ae7634ba735eef2a Cr-Commit-Position: refs/heads/master@{#384274}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M components/password_manager/core/browser/affiliated_match_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/affiliated_match_helper_unittest.cc View 6 chunks +14 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/test_password_store.cc View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
kolos1
Hi Balazs, Please review this CL that introduces prefetching for blacklisted logins too. Regards, Maxim
4 years, 8 months ago (2016-03-29 12:55:30 UTC) #4
engedy
LGTM, thank you!
4 years, 8 months ago (2016-03-29 14:20:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838183002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838183002/40001
4 years, 8 months ago (2016-03-31 13:58:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 8 months ago (2016-03-31 14:40:45 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 14:41:59 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d12aeb8306eaf1df7259b8a5ae7634ba735eef2a
Cr-Commit-Position: refs/heads/master@{#384274}

Powered by Google App Engine
This is Rietveld 408576698