Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: components/password_manager/core/browser/affiliated_match_helper_unittest.cc

Issue 1838183002: [Password Manager] Prefetch blacklisted Android credentials in AffiliatedMatchHelper's initializatio (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@android_credentials_blacklisted
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/affiliated_match_helper_unittest.cc
diff --git a/components/password_manager/core/browser/affiliated_match_helper_unittest.cc b/components/password_manager/core/browser/affiliated_match_helper_unittest.cc
index fa8d2b20e388cc324da56b8bcb95adc0d9744707..e9d8b0e57e2d2ca722201fb095d7eb511a698f3d 100644
--- a/components/password_manager/core/browser/affiliated_match_helper_unittest.cc
+++ b/components/password_manager/core/browser/affiliated_match_helper_unittest.cc
@@ -147,6 +147,13 @@ autofill::PasswordForm GetTestAndroidCredentials(const char* signon_realm) {
return form;
}
+autofill::PasswordForm GetTestBlacklistedAndroidCredentials(
+ const char* signon_realm) {
+ autofill::PasswordForm form = GetTestAndroidCredentials(signon_realm);
+ form.blacklisted_by_user = true;
+ return form;
+}
+
autofill::PasswordForm GetTestObservedWebForm(const char* signon_realm,
const char* origin) {
autofill::PasswordForm form;
@@ -199,6 +206,7 @@ class AffiliatedMatchHelperTest : public testing::Test {
void AddAndroidAndNonAndroidTestLogins() {
AddLogin(GetTestAndroidCredentials(kTestAndroidRealmAlpha3));
AddLogin(GetTestAndroidCredentials(kTestAndroidRealmBeta2));
+ AddLogin(GetTestBlacklistedAndroidCredentials(kTestAndroidRealmBeta3));
AddLogin(GetTestAndroidCredentials(kTestAndroidRealmGamma));
AddLogin(GetTestAndroidCredentials(kTestWebRealmAlpha1));
@@ -208,6 +216,7 @@ class AffiliatedMatchHelperTest : public testing::Test {
void RemoveAndroidAndNonAndroidTestLogins() {
RemoveLogin(GetTestAndroidCredentials(kTestAndroidRealmAlpha3));
RemoveLogin(GetTestAndroidCredentials(kTestAndroidRealmBeta2));
+ RemoveLogin(GetTestBlacklistedAndroidCredentials(kTestAndroidRealmBeta3));
RemoveLogin(GetTestAndroidCredentials(kTestAndroidRealmGamma));
RemoveLogin(GetTestAndroidCredentials(kTestWebRealmAlpha1));
@@ -218,6 +227,7 @@ class AffiliatedMatchHelperTest : public testing::Test {
mock_affiliation_service()->ExpectCallToPrefetch(
kTestAndroidFacetURIAlpha3);
mock_affiliation_service()->ExpectCallToPrefetch(kTestAndroidFacetURIBeta2);
+ mock_affiliation_service()->ExpectCallToPrefetch(kTestAndroidFacetURIBeta3);
mock_affiliation_service()->ExpectCallToPrefetch(kTestAndroidFacetURIGamma);
}
@@ -227,6 +237,8 @@ class AffiliatedMatchHelperTest : public testing::Test {
mock_affiliation_service()->ExpectCallToCancelPrefetch(
kTestAndroidFacetURIBeta2);
mock_affiliation_service()->ExpectCallToCancelPrefetch(
+ kTestAndroidFacetURIBeta3);
+ mock_affiliation_service()->ExpectCallToCancelPrefetch(
kTestAndroidFacetURIGamma);
}
@@ -236,6 +248,8 @@ class AffiliatedMatchHelperTest : public testing::Test {
mock_affiliation_service()->ExpectCallToTrimCacheForFacet(
kTestAndroidFacetURIBeta2);
mock_affiliation_service()->ExpectCallToTrimCacheForFacet(
+ kTestAndroidFacetURIBeta3);
+ mock_affiliation_service()->ExpectCallToTrimCacheForFacet(
kTestAndroidFacetURIGamma);
}

Powered by Google App Engine
This is Rietveld 408576698